From: Jason Baron <jbaron@redhat.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
rostedt@goodmis.org
Subject: Re: [PATCH] jump_label: jump_label for boot options.
Date: Thu, 1 Dec 2011 10:40:36 -0500 [thread overview]
Message-ID: <20111201154036.GA2443@redhat.com> (raw)
In-Reply-To: <20111201115353.563f79fc.kamezawa.hiroyu@jp.fujitsu.com>
On Thu, Dec 01, 2011 at 11:53:53AM +0900, KAMEZAWA Hiroyuki wrote:
> I tried to use jump_label for handling memcg's boot options which sets
> global variable true/false and never changes after boot. And found jump_table
> is larger than expected. This patch is a trial to allow to place jump_table
> in .init section. How do you think ?
>
Remeber too, that 'static_branch()' is inherently biased. That is, the
'false' path is assumed to be the the most likely path. Thus, the 'true'
path is move out-of-line. Thus, if the 'true' branch is potentially
used all the time, we would want to make sure that the savings of not
having to check a variable is still worth it. I should probably rename
static_branch() -> 'static_branch_default_false()' to make that clear.
Maybe we need an unbiased static_branch() too, but I'm not sure excatly
how to implement it...
Thanks,
-Jason
next prev parent reply other threads:[~2011-12-01 15:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 2:53 [PATCH] jump_label: jump_label for boot options KAMEZAWA Hiroyuki
2011-12-01 14:48 ` Steven Rostedt
2011-12-01 15:06 ` Peter Zijlstra
2011-12-01 16:14 ` Steven Rostedt
2011-12-01 15:07 ` Peter Zijlstra
2011-12-02 0:18 ` KAMEZAWA Hiroyuki
2011-12-01 15:05 ` Peter Zijlstra
2011-12-02 0:22 ` KAMEZAWA Hiroyuki
2011-12-02 9:24 ` Peter Zijlstra
2011-12-02 12:45 ` Johannes Weiner
2011-12-02 12:53 ` Peter Zijlstra
2011-12-07 10:16 ` Johannes Weiner
2011-12-01 15:40 ` Jason Baron [this message]
2011-12-01 16:28 ` Peter Zijlstra
2011-12-01 16:50 ` Jason Baron
2011-12-01 17:16 ` Jason Baron
2011-12-01 18:16 ` Peter Zijlstra
2011-12-01 17:39 ` Peter Zijlstra
2011-12-01 17:45 ` Peter Zijlstra
2011-12-01 21:13 ` Jason Baron
2011-12-01 22:08 ` Peter Zijlstra
2011-12-02 0:28 ` KAMEZAWA Hiroyuki
2011-12-02 5:34 ` Mike Galbraith
2011-12-02 5:47 ` KAMEZAWA Hiroyuki
2011-12-02 8:39 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111201154036.GA2443@redhat.com \
--to=jbaron@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.