All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Eric B Munson <emunson@mgebm.net>
Cc: avi@redhat.com, mingo@redhat.com, hpa@zytor.com, arnd@arndb.de,
	ryanh@linux.vnet.ibm.com, aliguori@us.ibm.com,
	jeremy.fitzhardinge@citrix.com, kvm@vger.kernel.org,
	linux-arch@vger.kernel.org, x86@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5 V4]  Avoid soft lockup message when KVM is stopped by host
Date: Thu, 1 Dec 2011 19:25:58 -0200	[thread overview]
Message-ID: <20111201212558.GC25290@amt.cnet> (raw)
In-Reply-To: <1322602539-27004-1-git-send-email-emunson@mgebm.net>

On Tue, Nov 29, 2011 at 04:35:34PM -0500, Eric B Munson wrote:
> Changes from V3:
> Include CC's on patch 3
> Drop clear flag ioctl and have the watchdog clear the flag when it is reset
> 
> Changes from V2:
> A new kvm functions defined in kvm_para.h, the only change to pvclock is the
> initial flag definition
> 
> Changes from V1:
> (Thanks Marcelo)
> Host code has all been moved to arch/x86/kvm/x86.c
> KVM_PAUSE_GUEST was renamed to KVM_GUEST_PAUSED
> 
> When a guest kernel is stopped by the host hypervisor it can look like a soft
> lockup to the guest kernel.  This false warning can mask later soft lockup
> warnings which may be real.  This patch series adds a method for a host
> hypervisor to communicate to a guest kernel that it is being stopped.  The
> final patch in the series has the watchdog check this flag when it goes to
> issue a soft lockup warning and skip the warning if the guest knows it was
> stopped.
> 
> It was attempted to solve this in Qemu, but the side effects of saving and
> restoring the clock and tsc for each vcpu put the wall clock of the guest behind
> by the amount of time of the pause.  This forces a guest to have ntp running
> in order to keep the wall clock accurate.

Looks good to me.

      parent reply	other threads:[~2011-12-01 21:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 21:35 [PATCH 0/5 V4] Avoid soft lockup message when KVM is stopped by host Eric B Munson
2011-11-29 21:35 ` [PATCH 1/5 V4] Add flag to indicate that a vm was stopped by the host Eric B Munson
2011-11-29 21:35 ` [PATCH 2/5 V4] Add functions to check if the host has stopped the vm Eric B Munson
2011-11-29 21:35 ` [PATCH 3/5 V4] Add ioctl for KVM_GUEST_STOPPED Eric B Munson
2011-12-03  9:16   ` Sasha Levin
2011-12-05 18:00     ` Eric B Munson
2011-11-29 21:35 ` [PATCH 4/5 V4] Add generic stubs for kvm stop check functions Eric B Munson
2011-11-29 21:35 ` [PATCH 5/5 V4] Add check for suspended vm in softlockup detector Eric B Munson
2011-12-01 21:25 ` Marcelo Tosatti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111201212558.GC25290@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=arnd@arndb.de \
    --cc=avi@redhat.com \
    --cc=emunson@mgebm.net \
    --cc=hpa@zytor.com \
    --cc=jeremy.fitzhardinge@citrix.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=ryanh@linux.vnet.ibm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.