Re: [PATCH-v5 5/6] Bluetooth: Add MITM mechanism to LE-SMP

[Gustavo Padovan <padovan@profusion.mobi>]

Hi Brian,

* Brian Gix <bgix@codeaurora.org> [2011-12-01 10:35:30 -0800]:

> On 12/1/2011 6:11 AM, Gustavo Padovan wrote:
> >Hi Brian,
> 
> >>diff --git a/include/net/bluetooth/smp.h b/include/net/bluetooth/smp.h
> >>index 15b97d5..43b6c49 100644
> >>--- a/include/net/bluetooth/smp.h
> >>+++ b/include/net/bluetooth/smp.h
> >>@@ -124,6 +124,8 @@ struct smp_chan {
> >>  	u8		pcnf[16]; /* SMP Pairing Confirm */
> >>  	u8		tk[16]; /* SMP Temporary Key */
> >>  	u8		smp_key_size;
> >>+	u8		smp_tk_valid;
> >>+	u8		smp_cfm_pending;
> >
> >Those two could be converted in a bitfield, you are using them as boolean.
> >
> 
> Is there a mandate that bitfields must be manipulated/checked with
> the clear_bit/set_bit/test_bit prototypes?  Or can I just use a
> single u8 to represent both boolean values (as opposed to an
> unsigned long), and use standard &=, |= and & to set/clear/check?

Please use clear/set/test_bit, it is the right way.

	Gustavo