All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Alessandro Rubini <rubini@gnudd.com>
Cc: linux-kernel@vger.kernel.org, rusty@ozlabs.org, siglesia@cern.ch,
	manohar.vanga@cern.ch, dave.martin@linaro.org
Subject: Re: [RFC PATCH V2 0/1] making order in file2alias
Date: Thu, 1 Dec 2011 16:03:50 -0800	[thread overview]
Message-ID: <20111202000350.GA6507@kroah.com> (raw)
In-Reply-To: <cover.1322781825.git.rubini@gnudd.com>

On Fri, Dec 02, 2011 at 12:45:25AM +0100, Alessandro Rubini wrote:
> (this message is the RFC, the patch itself is expected to be fine)
> 
> This is a repost of what I've sent on Nov 4th.  Since Rusty asked to
> only do the first step, here it is.  I rebased on next-20111201 and it
> still works fine.

Well, some of us disagree with Rusty :)

As he's still the maintainer of the module code, I'll defer to him
though.

> As for the previous 2/2 (see https://lkml.org/lkml/2011/11/4/127 ),
> I still think it makes sense. And as Dave Martin suggested, we can
> do without the array.
> 
> Thus, I may prepare three smaller steps, if that's acceptable (greg?)
> 
>   step 1: create the ELF section so ENTRY() lines can leave the array
>           (and change name accordingly).
> 
>   step 2: each ENTRY() line can be moved just after the associated code
>           (this means that a new bus is just a single hunk, not 2 of them)
> 
>   step 3: I create the headers needed to move code and ENTRY in separate
>           files. This is some movement around, not trivial so it may
>           deserve a patch in itself.
> 
>   step 4 and later ones: Individual busses may reach their own external file,
>          conditionally compiled per Kconfig rules.
> 
> If that's something worth evaluating, I can do that over the weekend.

That sounds very reasonable to me.

thanks,

greg k-h

  parent reply	other threads:[~2011-12-02  0:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-01 23:45 [RFC PATCH V2 0/1] making order in file2alias Alessandro Rubini
2011-12-01 23:45 ` [PATCH V2 1/1] modpost: use table-lookup to build module aliases Alessandro Rubini
2011-12-02  0:04   ` Greg KH
2011-12-02  0:03 ` Greg KH [this message]
2011-12-02  2:46   ` [RFC PATCH V2 0/1] making order in file2alias Rusty Russell
2011-12-02  8:42     ` Alessandro Rubini
2011-12-02 19:27       ` Greg KH
2011-12-03  4:51         ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111202000350.GA6507@kroah.com \
    --to=greg@kroah.com \
    --cc=dave.martin@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manohar.vanga@cern.ch \
    --cc=rubini@gnudd.com \
    --cc=rusty@ozlabs.org \
    --cc=siglesia@cern.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.