From: Thomas Jarosch <thomas.jarosch@intra2net.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: Small glitch in neptune ethernet driver
Date: Fri, 2 Dec 2011 09:49:32 +0100 [thread overview]
Message-ID: <201112020949.32369.thomas.jarosch@intra2net.com> (raw)
In-Reply-To: <20111201.220003.905428158537118068.davem@davemloft.net>
On Friday, 2. December 2011 04:00:03 David Miller wrote:
> diff --git a/drivers/net/ethernet/sun/niu.c
> b/drivers/net/ethernet/sun/niu.c index 680b107..56d106e 100644
> --- a/drivers/net/ethernet/sun/niu.c
> +++ b/drivers/net/ethernet/sun/niu.c
> @@ -8579,9 +8579,11 @@ static int __devinit phy_record(struct niu_parent
> *parent, if (dev_id_1 < 0 || dev_id_2 < 0)
> return 0;
> if (type == PHY_TYPE_PMA_PMD || type == PHY_TYPE_PCS) {
> + /* Becuase of the NIU_PHY_ID_MASK being applied, the 8704
The change looks good to me, just fix the typo in "Becuase".
Thanks,
Thomas
next prev parent reply other threads:[~2011-12-02 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 17:39 Small glitch in neptune ethernet driver Thomas Jarosch
2011-12-02 3:00 ` David Miller
2011-12-02 8:49 ` Thomas Jarosch [this message]
2011-12-02 17:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112020949.32369.thomas.jarosch@intra2net.com \
--to=thomas.jarosch@intra2net.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.