From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753592Ab1LBJ6L (ORCPT ); Fri, 2 Dec 2011 04:58:11 -0500 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:37063 "EHLO e23smtp06.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753210Ab1LBJ6J (ORCPT ); Fri, 2 Dec 2011 04:58:09 -0500 Date: Fri, 2 Dec 2011 15:27:56 +0530 From: Kamalesh Babulal To: Michal Hocko Cc: linux-kernel@vger.kernel.org, Arjan van de Ven , Thomas Gleixner Subject: Re: [PATCH] nohz: Remove update_ts_time_stat from tick_nohz_start_idle Message-ID: <20111202095756.GB15975@linux.vnet.ibm.com> Reply-To: Kamalesh Babulal References: <1322755222-6951-1-git-send-email-mhocko@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1322755222-6951-1-git-send-email-mhocko@suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) x-cbid: 11120123-7014-0000-0000-00000031DB25 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Michal Hocko [2011-12-01 17:00:22]: > There is no reason to call update_ts_time_stat from tick_nohz_start_idle > anymore (after e0e37c20 sched: Eliminate the ts->idle_lastupdate field) > when we updated idle_lastupdate unconditionally. > > We haven't set idle_active yet and do not provide last_update_time so > the whole call end up being just 2 wasted branches. > > Signed-off-by: Michal Hocko > CC: Arjan van de Ven > CC: Thomas Gleixner Reviewed-by: Kamalesh Babulal