From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: Make sure IPaddr_t is 32 bits in size
Date: Fri, 2 Dec 2011 11:48:11 -0500 [thread overview]
Message-ID: <201112021148.12459.vapier@gentoo.org> (raw)
In-Reply-To: <1322843172-20251-1-git-send-email-weisserm@arcor.de>
On Friday 02 December 2011 11:26:12 Matthias Weisser wrote:
> When building u-boot as 64 bit application (e.g. sandbox) ulong might be
> 64 bits in size. This breaks network code as IPaddr_t is 64 bytes in
> size then. This patch makes sure that IPaddr_t is always 32 bits in
> size. Also some warnings introduced by this patch are fixed.
on 2nd thought, could you clarify why we want it to be 32bits ? it's because
that's the size of the address field in an IPv4 packet ...
> --- a/include/net.h
> +++ b/include/net.h
>
> -typedef ulong IPaddr_t;
> +typedef u32 IPaddr_t;
and add a comment here too ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111202/63b3aa26/attachment.pgp>
next prev parent reply other threads:[~2011-12-02 16:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 16:26 [U-Boot] [PATCH] net: Make sure IPaddr_t is 32 bits in size Matthias Weisser
2011-12-02 16:47 ` Mike Frysinger
2011-12-02 16:48 ` Mike Frysinger [this message]
2011-12-03 13:29 ` [U-Boot] [PATCH V2] " Matthias Weisser
2011-12-06 21:15 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112021148.12459.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.