From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Wang2 <wei.wang2@amd.com>
Subject: Re: [PATCH] AMD IOMMU v2: minor cleanup
Date: Fri, 2 Dec 2011 14:15:33 +0100
Message-ID: <201112021415.34215.wei.wang2@amd.com>
References: <16f5f59b-7d8e-4e8f-a178-be3f2ccf338a@sausexedgep01.amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <16f5f59b-7d8e-4e8f-a178-be3f2ccf338a@sausexedgep01.amd.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@suse.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Thursday 01 December 2011 12:56:36 Jan Beulich wrote:
> Despite this array living in an __init function, having such be an
> automatic variable is rather inefficient in terms of generated code.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/drivers/passthrough/amd/iommu_detect.c
> +++ b/xen/drivers/passthrough/amd/iommu_detect.c
> @@ -66,7 +66,7 @@ void __init get_iommu_features(struct am
>  {
>      u32 low, high;
>      int i = 0 ;
> -    char * feature_str[] = {
> +    static const char *__initdata feature_str[] = {
>          "- Prefetch Pages Command",
>          "- Peripheral Page Service Request",
>          "- X2APIC Supported",


Acked, thanks,
Wei