From: Alessandro Rubini <rubini@gnudd.com>
To: rupran@einserver.de
Cc: devel@linuxdriverproject.org, gregkh@suse.de, jic23@cam.ac.uk,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/2] Staging: iio/accel: Changed data type of mask in store_measurement_mode() to u8
Date: Fri, 2 Dec 2011 17:44:23 +0100 [thread overview]
Message-ID: <20111202164423.GA14982@mail.gnudd.com> (raw)
In-Reply-To: <1322843423-18178-1-git-send-email-rupran@einserver.de>
> As we are only interested in the lowest two bytes here and mask is
> initialized with a fixed value 0x03, mask may as well be a u8.
s/bytes/bits/
It's not a trivial typo, the reader can be confused (I've been)
/alessandro
next prev parent reply other threads:[~2011-12-02 16:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111124205657.GL3258@mwanda>
2011-11-27 22:17 ` [PATCH 1/3] Staging: iio/accel: Changed data type in adis16220_write_16bit to u16 Andreas Ruprecht
2011-11-27 22:17 ` [PATCH 2/3] Staging: iio/accel: Changed data type for val to unsigned long in write_frequency Andreas Ruprecht
2011-12-01 21:08 ` Jonathan Cameron
2011-11-27 22:17 ` [PATCH 3/3] Staging: iio/accel: Changed data type of val in store_measurement_mode to u8 Andreas Ruprecht
2011-12-01 21:13 ` Jonathan Cameron
2011-12-02 16:30 ` [PATCH 1/2] Staging: iio/accel: Changed data type of mask in store_measurement_mode() " Andreas Ruprecht
2011-12-02 16:30 ` [PATCH 2/2] Staging: iio/accel: Added a range check for val in store_measurement_mode() Andreas Ruprecht
2011-12-02 16:44 ` Alessandro Rubini [this message]
2011-12-02 16:56 ` [PATCH v2 1/2] Staging: iio/accel: Changed data type of mask in store_measurement_mode() to u8 Andreas Ruprecht
2011-12-01 21:05 ` [PATCH 1/3] Staging: iio/accel: Changed data type in adis16220_write_16bit to u16 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111202164423.GA14982@mail.gnudd.com \
--to=rubini@gnudd.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=rupran@einserver.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.