All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	fengguang.wu@intel.com
Subject: Re: Add simple way to add statistic counters to debugfs
Date: Fri, 2 Dec 2011 11:18:24 -0800	[thread overview]
Message-ID: <20111202191824.GB13613@kroah.com> (raw)
In-Reply-To: <1322851407-17182-1-git-send-email-andi@firstfloor.org>

On Fri, Dec 02, 2011 at 10:43:24AM -0800, Andi Kleen wrote:
> This extends debugfs to make it very simple to add per cpu counters
> statistics that are exported there. This is useful for all kind
> of debugging situations. The counters have very little overhead
> and are simpler to use than trace points.
> 
> This is the infrastructure for debugfs and a demo application 
> to instrument the dcache RCU which I developed some time ago
> to track down some problems there.
> 
> Posting here also so that Fengguang can use it.
> 
> Module support is still missing, but could be added without too 
> much work.

I like this a lot, very nice job.  I just had one comment with the first
patch.

And yes, I would like module support as well, but others can add that if
they really need it :)

Care to fix up the first patch and I'll be glad to take the two debugfs
patches and any others if you want me to.

thanks,

greg k-h

      parent reply	other threads:[~2011-12-02 19:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-02 18:43 Add simple way to add statistic counters to debugfs Andi Kleen
2011-12-02 18:43 ` [PATCH 1/3] DEBUGFS: Automatically create parents for debugfs files Andi Kleen
2011-12-02 19:17   ` Greg KH
2011-12-02 19:42     ` Andi Kleen
2011-12-02 19:58       ` Greg KH
2011-12-02 18:43 ` [PATCH 2/3] DEBUGFS: Add per cpu counters Andi Kleen
2011-12-06 11:44   ` Wu Fengguang
2011-12-06 17:17     ` Andi Kleen
2011-12-09  3:00       ` Wu Fengguang
2011-12-02 18:43 ` [PATCH 3/3] VFS: Add event counting to dcache Andi Kleen
2011-12-02 19:18 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111202191824.GB13613@kroah.com \
    --to=greg@kroah.com \
    --cc=andi@firstfloor.org \
    --cc=fengguang.wu@intel.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.