Re: [PATCH-RFC 10/10] sparc: switch to GENERIC_PCI_IOMAP

["Michael S. Tsirkin" <mst@redhat.com>]

On Sun, Dec 04, 2011 at 12:26:19PM +0100, Sam Ravnborg wrote:
>     > --- a/arch/sparc/include/asm/io_32.h
>     > +++ b/arch/sparc/include/asm/io_32.h
>     > @@ -8,6 +8,10 @@
>     >  #include <asm/page.h>      /* IO address mapping routines need this */
>     >  #include <asm/system.h>
>     >
>     > +#ifdef __KERNEL__
>     > +#include <asm-generic/pci_iomap.h>
>     > +#endif
>     > +
> 
> This file is not exported to userspace - so the test for __KERNEL__ can be
> dropped.
>  
> 
>     > diff --git a/arch/sparc/include/asm/io_64.h b/arch/sparc/include/asm/
>     io_64.h
>     > index 9c89654..19cd51d 100644
>     > --- a/arch/sparc/include/asm/io_64.h
>     > +++ b/arch/sparc/include/asm/io_64.h
>     > @@ -9,6 +9,10 @@
>     >  #include <asm/system.h>
>     >  #include <asm/asi.h>
>     >
>     > +#ifdef __KERNEL__
>     > +#include <asm-generic/pci_iomap.h>
>     > +#endif
> 
> Likewise
> 
>    Sam
> 
>     Sam

Hmm.
Why is there an #ifdef __KERNEL__ a bit lower?
That's why I put the includes within ifdef __KERNEL__ - the
definitions pulled in were within ifdef __KERNEL__ originally.

-- 
MST