From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/9] drivers/mtd/nand/nand_spl_simple.c: Fix GCC 4.6 warnings
Date: Sun, 4 Dec 2011 12:24:47 +0100 [thread overview]
Message-ID: <201112041224.47897.marek.vasut@gmail.com> (raw)
In-Reply-To: <1322930775-4767-2-git-send-email-agust@denx.de>
> Fix warnings for both cases:
>
> definded CONFIG_SYS_NAND_HW_ECC_OOBFIRST:
> nand_spl_simple.c: In function 'nand_read_page':
> nand_spl_simple.c:156:6: warning: variable 'stat' set but not used
> [-Wunused-but-set-variable]
>
> not definded CONFIG_SYS_NAND_HW_ECC_OOBFIRST:
> nand_spl_simple.c: In function 'nand_read_page':
> nand_spl_simple.c:196:6: warning: variable 'stat' set but not used
> [-Wunused-but-set-variable]
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Scott Wood <scottwood@freescale.com>
> ---
> drivers/mtd/nand/nand_spl_simple.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_spl_simple.c
> b/drivers/mtd/nand/nand_spl_simple.c index ed821f2..7eb08a3 100644
> --- a/drivers/mtd/nand/nand_spl_simple.c
> +++ b/drivers/mtd/nand/nand_spl_simple.c
> @@ -153,7 +153,6 @@ static int nand_read_page(int block, int page, uchar
> *dst) int eccbytes = CONFIG_SYS_NAND_ECCBYTES;
> int eccsteps = CONFIG_SYS_NAND_ECCSTEPS;
> uint8_t *p = dst;
> - int stat;
>
> /*
> * No malloc available for now, just use some temporary locations
> @@ -176,7 +175,7 @@ static int nand_read_page(int block, int page, uchar
> *dst) this->ecc.hwctl(&mtd, NAND_ECC_READ);
> this->read_buf(&mtd, p, eccsize);
> this->ecc.calculate(&mtd, p, &ecc_calc[i]);
> - stat = this->ecc.correct(&mtd, p, &ecc_code[i], &ecc_calc[i]);
> + this->ecc.correct(&mtd, p, &ecc_code[i], &ecc_calc[i]);
> }
>
> return 0;
> @@ -193,7 +192,6 @@ static int nand_read_page(int block, int page, void
> *dst) int eccbytes = CONFIG_SYS_NAND_ECCBYTES;
> int eccsteps = CONFIG_SYS_NAND_ECCSTEPS;
> uint8_t *p = dst;
> - int stat;
>
> nand_command(block, page, 0, NAND_CMD_READ0);
>
> @@ -224,7 +222,7 @@ static int nand_read_page(int block, int page, void
> *dst) * from correct_data(). We just hope that all possible errors
> * are corrected by this routine.
> */
> - stat = this->ecc.correct(&mtd, p, &ecc_code[i], &ecc_calc[i]);
> + this->ecc.correct(&mtd, p, &ecc_code[i], &ecc_calc[i]);
> }
>
> return 0;
Acked-by: Marek Vasut <marek.vasut@gmail.com>
next prev parent reply other threads:[~2011-12-04 11:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-03 16:46 [U-Boot] [PATCH 1/9] common/menu.c: Fix build warning Anatolij Gustschin
2011-12-03 16:46 ` [U-Boot] [PATCH 2/9] drivers/mtd/nand/nand_spl_simple.c: Fix GCC 4.6 warnings Anatolij Gustschin
2011-12-04 9:07 ` Heiko Schocher
2011-12-04 11:24 ` Marek Vasut [this message]
2011-12-07 22:10 ` Scott Wood
2011-12-03 16:46 ` [U-Boot] [PATCH 3/9] drivers/mtd/nand/nand_spl_load.c: Fix GCC 4.6 warning Anatolij Gustschin
2011-12-04 9:15 ` Heiko Schocher
2011-12-04 11:24 ` Marek Vasut
2011-12-07 22:11 ` Scott Wood
2011-12-03 16:46 ` [U-Boot] [PATCH 4/9] drivers/usb/musb/musb_udc.c: " Anatolij Gustschin
2011-12-04 11:10 ` Remy Bohmer
2011-12-04 11:25 ` Marek Vasut
2011-12-09 9:36 ` Wolfgang Denk
2011-12-03 16:46 ` [U-Boot] [PATCH 5/9] drivers/usb/gadget/core.c: " Anatolij Gustschin
2011-12-04 11:06 ` Remy Bohmer
2011-12-04 11:27 ` Marek Vasut
2011-12-09 9:37 ` Wolfgang Denk
2011-12-03 16:46 ` [U-Boot] [PATCH 6/9] drivers/usb/gadget/ep0.c: " Anatolij Gustschin
2011-12-04 11:11 ` Remy Bohmer
2011-12-04 11:28 ` Marek Vasut
2011-12-09 9:37 ` Wolfgang Denk
2011-12-03 16:46 ` [U-Boot] [PATCH 7/9] arch/arm/cpu/armv7/omap-common/spl.c: Fix GCC 4.2 warnings Anatolij Gustschin
2011-12-04 11:28 ` Marek Vasut
2011-12-05 15:04 ` Tom Rini
2011-12-03 16:46 ` [U-Boot] [PATCH 8/9] arch/arm/cpu/armv7/omap-common/clocks-common.c: Fix GCC 4.6 warnings Anatolij Gustschin
2011-12-04 11:29 ` Marek Vasut
2011-12-05 15:02 ` Tom Rini
2011-12-05 16:32 ` Anatolij Gustschin
2011-12-05 17:11 ` Tom Rini
2011-12-03 16:46 ` [U-Boot] [PATCH 9/9] arch/arm/include/asm/arch-omap5/clocks.h: Fix GCC 4.2 warnings Anatolij Gustschin
2011-12-04 11:30 ` Marek Vasut
2011-12-04 13:59 ` Anatolij Gustschin
2011-12-05 15:08 ` Tom Rini
2011-12-06 5:52 ` R, Sricharan
2011-12-04 9:17 ` [U-Boot] [PATCH 1/9] common/menu.c: Fix build warning Heiko Schocher
2011-12-04 11:27 ` Marek Vasut
2011-12-04 11:49 ` Anatolij Gustschin
2011-12-05 22:26 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112041224.47897.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.