All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
	linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
	stable-rt@vger.kernel.org
Subject: [PATCH 06/11] wait: Provide __wake_up_all_locked
Date: Sun, 04 Dec 2011 13:54:50 -0500	[thread overview]
Message-ID: <20111204190015.658345057@goodmis.org> (raw)
In-Reply-To: 20111204185444.411298317@goodmis.org

[-- Attachment #1: Type: text/plain, Size: 2422 bytes --]

From: Thomas Gleixner <tglx@linutronix.de>

For code which protects the waitqueue itself with another lock it
makes no sense to acquire the waitqueue lock for wakeup all. Provide
__wake_up_all_locked.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable-rt@vger.kernel.org
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 include/linux/wait.h |    5 +++--
 kernel/sched.c       |    4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/include/linux/wait.h b/include/linux/wait.h
index 3efc9f3..1e904b8 100644
--- a/include/linux/wait.h
+++ b/include/linux/wait.h
@@ -157,7 +157,7 @@ void __wake_up(wait_queue_head_t *q, unsigned int mode, int nr, void *key);
 void __wake_up_locked_key(wait_queue_head_t *q, unsigned int mode, void *key);
 void __wake_up_sync_key(wait_queue_head_t *q, unsigned int mode, int nr,
 			void *key);
-void __wake_up_locked(wait_queue_head_t *q, unsigned int mode);
+void __wake_up_locked(wait_queue_head_t *q, unsigned int mode, int nr);
 void __wake_up_sync(wait_queue_head_t *q, unsigned int mode, int nr);
 void __wake_up_bit(wait_queue_head_t *, void *, int);
 int __wait_on_bit(wait_queue_head_t *, struct wait_bit_queue *, int (*)(void *), unsigned);
@@ -170,7 +170,8 @@ wait_queue_head_t *bit_waitqueue(void *, int);
 #define wake_up(x)			__wake_up(x, TASK_NORMAL, 1, NULL)
 #define wake_up_nr(x, nr)		__wake_up(x, TASK_NORMAL, nr, NULL)
 #define wake_up_all(x)			__wake_up(x, TASK_NORMAL, 0, NULL)
-#define wake_up_locked(x)		__wake_up_locked((x), TASK_NORMAL)
+#define wake_up_locked(x)		__wake_up_locked((x), TASK_NORMAL, 1)
+#define wake_up_all_locked(x)		__wake_up_locked((x), TASK_NORMAL, 0)
 
 #define wake_up_interruptible(x)	__wake_up(x, TASK_INTERRUPTIBLE, 1, NULL)
 #define wake_up_interruptible_nr(x, nr)	__wake_up(x, TASK_INTERRUPTIBLE, nr, NULL)
diff --git a/kernel/sched.c b/kernel/sched.c
index 640f740..63aeba0 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -4642,9 +4642,9 @@ EXPORT_SYMBOL(__wake_up);
 /*
  * Same as __wake_up but called with the spinlock in wait_queue_head_t held.
  */
-void __wake_up_locked(wait_queue_head_t *q, unsigned int mode)
+void __wake_up_locked(wait_queue_head_t *q, unsigned int mode, int nr)
 {
-	__wake_up_common(q, mode, 1, 0, NULL);
+	__wake_up_common(q, mode, nr, 0, NULL);
 }
 EXPORT_SYMBOL_GPL(__wake_up_locked);
 
-- 
1.7.7.1



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2011-12-04 18:54 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-04 18:54 [PATCH 00/11] [ANNOUNCE] 3.0.12-rt30-rc2 Steven Rostedt
2011-12-04 18:54 ` [PATCH 01/11] tasklet/rt: Prevent tasklets from going into infinite spin in RT Steven Rostedt
2011-12-04 18:54 ` [PATCH 02/11] genirq: fix regression in irqfixup, irqpoll Steven Rostedt
2011-12-04 18:54 ` [PATCH 03/11] intel-iommu: Fix AB-BA lockdep report Steven Rostedt
2012-11-14  2:25   ` Shuah Khan
2012-11-14  3:04     ` Steven Rostedt
2012-11-14  3:34       ` Greg Kroah-Hartman
2012-11-14  3:43         ` Steven Rostedt
2012-11-14  3:43           ` Steven Rostedt
2012-11-14 15:58         ` Shuah Khan
2011-12-04 18:54 ` [PATCH 04/11] KVM: Sanitize cpuid Steven Rostedt
2011-12-04 18:54 ` [PATCH 05/11] KVM: fix XSAVE bit scanning (now properly) Steven Rostedt
2011-12-04 18:54 ` Steven Rostedt [this message]
2011-12-04 18:54 ` [PATCH 07/11] pci: Use __wake_up_all_locked pci_unblock_user_cfg_access() Steven Rostedt
2011-12-04 18:54 ` [PATCH 08/11] acpi: Make gbl_[hardware|gpe]_lock raw Steven Rostedt
2011-12-04 18:54 ` [PATCH 09/11] slab, lockdep: Fix silly bug Steven Rostedt
2011-12-05 13:04   ` Pekka Enberg
2011-12-05 13:04     ` Pekka Enberg
2011-12-05 13:15     ` Steven Rostedt
2011-12-05 13:15       ` Steven Rostedt
2011-12-04 18:54 ` [PATCH 10/11] slab, lockdep: Annotate all slab caches Steven Rostedt
2011-12-04 18:54 ` [PATCH 11/11] Linux v3.0.12-rt30-rc2 Steven Rostedt
2011-12-04 20:13 ` [PATCH 00/11] [ANNOUNCE] 3.0.12-rt30-rc2 Tim Sander
2011-12-04 20:46   ` Thomas Gleixner
2011-12-05  9:11     ` Tim Sander
2011-12-05 13:23       ` Steven Rostedt
2011-12-07  8:09         ` Tim Sander
2011-12-07  8:09           ` Tim Sander
2011-12-05  2:58   ` Mike Galbraith
2011-12-05 15:12 ` Georgiewskiy Yuriy
2011-12-05 15:12   ` Georgiewskiy Yuriy
2011-12-05 16:57   ` Thomas Gleixner
2011-12-05 20:01     ` Georgiewskiy Yuriy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111204190015.658345057@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=C.Emde@osadl.org \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=stable-rt@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.