From: Thierry Reding <thierry.reding@avionic-design.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 07/21] ASoC: Convert WM8741 to devm_kzalloc()
Date: Mon, 5 Dec 2011 07:59:31 +0100 [thread overview]
Message-ID: <20111205065931.GA7341@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <1322948009-27658-7-git-send-email-broonie@opensource.wolfsonmicro.com>
[-- Attachment #1.1: Type: text/plain, Size: 826 bytes --]
* Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/wm8741.c | 16 ++++------------
> 1 files changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8741.c b/sound/soc/codecs/wm8741.c
> index bf471dc..24d8ec5 100644
> --- a/sound/soc/codecs/wm8741.c
> +++ b/sound/soc/codecs/wm8741.c
[...]
> @@ -512,20 +513,13 @@ static int wm8741_i2c_probe(struct i2c_client *i2c,
>
> ret = snd_soc_register_codec(&i2c->dev,
> &soc_codec_dev_wm8741, &wm8741_dai, 1);
> - if (ret != 0)
> - goto err;
>
> return ret;
> -
> -err:
> - kfree(wm8741);
> - return ret;
> }
Any particular reason why this is not collapsed into:
return snd_soc_register_codec(...)
The same goes for patches 8 and 9.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2011-12-05 6:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-03 21:33 [PATCH 01/21] ASoC: Remove unused -codec from Wolfson device driver names Mark Brown
2011-12-03 21:33 ` [PATCH 02/21] ASoC: Remove I2C ifdefs from WM8960 Mark Brown
2011-12-03 21:33 ` [PATCH 03/21] ASoC: Remove unused AUDIO_NAME define " Mark Brown
2011-12-03 21:33 ` [PATCH 04/21] ASoC: Convert WM2000 to devm_kzalloc() Mark Brown
2011-12-03 21:33 ` [PATCH 05/21] ASoC: Convert WM8350 " Mark Brown
2011-12-03 21:33 ` [PATCH 06/21] ASoC: Convert WM8400 " Mark Brown
2011-12-03 21:33 ` [PATCH 07/21] ASoC: Convert WM8741 " Mark Brown
2011-12-05 6:59 ` Thierry Reding [this message]
2011-12-05 12:08 ` Mark Brown
2011-12-03 21:33 ` [PATCH 08/21] ASoC: Convert WM8750 " Mark Brown
2011-12-03 21:33 ` [PATCH 09/21] ASoC: Convert WM9090 " Mark Brown
2011-12-03 21:33 ` [PATCH 10/21] ASoC: Convert WM8350 to table based DAPM and control init Mark Brown
2011-12-03 21:33 ` [PATCH 11/21] ASoC: Convert WM8400 " Mark Brown
2011-12-03 21:33 ` [PATCH 12/21] ASoC: Convert WM8510 " Mark Brown
2011-12-03 21:33 ` [PATCH 13/21] ASoC: Convert WM8580 " Mark Brown
2011-12-03 21:33 ` [PATCH 14/21] ASoC: Convert WM8741 " Mark Brown
2011-12-03 21:33 ` [PATCH 15/21] ASoC: Convert WM8750 " Mark Brown
2011-12-03 21:33 ` [PATCH 16/21] ASoC: Convert WM8711 to table based " Mark Brown
2011-12-03 21:33 ` [PATCH 17/21] ASoC: Convert WM8728 " Mark Brown
2011-12-03 21:33 ` [PATCH 18/21] ASoC: Remove unused struct wm2000_setup_data Mark Brown
2011-12-03 21:33 ` [PATCH 19/21] ASoC: Convert wm2000 to use regmap API Mark Brown
2011-12-03 21:33 ` [PATCH 20/21] ASoC: Convert WM2000 into a standard CODEC driver Mark Brown
2011-12-03 21:33 ` [PATCH 21/21] ASoC: Sort WM9090 in with the CODEC drivers Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205065931.GA7341@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.