From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xensource.com
Subject: Re: [PATCH] mem_event: use wait queue when ring is full
Date: Mon, 5 Dec 2011 12:33:16 +0100 [thread overview]
Message-ID: <20111205113316.GA29024@aepfle.de> (raw)
In-Reply-To: <cd163bcd0f066e52ee74.1323083943@probook.site>
On Mon, Dec 05, Olaf Hering wrote:
> Wakeup will take the number of free slots into account.
This is not entirely tree unless this additional change is applied:
diff -r cd163bcd0f06 xen/arch/x86/mm/mem_event.c
--- a/xen/arch/x86/mm/mem_event.c
+++ b/xen/arch/x86/mm/mem_event.c
@@ -235,6 +235,7 @@ void mem_event_wake_requesters(struct me
mem_event_ring_lock(med);
free_req = RING_FREE_REQUESTS(&med->front_ring);
+ free_req -= med->foreign_producers;
if ( free_req )
wake_up_nr(&med->wq, free_req);
And perhaps the wake_up should be done outside the ring lock?
Olaf
next prev parent reply other threads:[~2011-12-05 11:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 11:19 [PATCH] mem_event: use wait queue when ring is full Olaf Hering
2011-12-05 11:33 ` Olaf Hering [this message]
[not found] <mailman.3332.1323083995.12970.xen-devel@lists.xensource.com>
2011-12-05 15:45 ` Andres Lagar-Cavilla
2011-12-05 16:20 ` Olaf Hering
2011-12-05 16:34 ` Andres Lagar-Cavilla
2011-12-07 13:20 ` Olaf Hering
2011-12-07 16:27 ` Andres Lagar-Cavilla
-- strict thread matches above, loose matches on Subject: below --
2011-12-09 19:23 Olaf Hering
2011-12-15 12:43 ` Tim Deegan
2011-12-15 13:15 ` Olaf Hering
[not found] <mailman.3873.1323460242.12970.xen-devel@lists.xensource.com>
2011-12-10 5:22 ` Andres Lagar-Cavilla
2011-12-13 13:40 ` Olaf Hering
[not found] <mailman.4227.1323785898.12970.xen-devel@lists.xensource.com>
2011-12-15 14:56 ` Andres Lagar-Cavilla
2011-12-16 16:40 ` Olaf Hering
2011-12-16 17:04 ` Andres Lagar-Cavilla
2011-12-16 17:33 ` Olaf Hering
2011-12-19 11:39 Olaf Hering
2011-12-22 11:27 ` Tim Deegan
[not found] <mailman.4853.1324294828.12970.xen-devel@lists.xensource.com>
2012-01-11 18:02 ` Andres Lagar-Cavilla
2012-01-12 13:59 ` Olaf Hering
2012-01-12 16:11 ` Andres Lagar-Cavilla
2012-01-12 17:50 ` Adin Scannell
[not found] ` <B28ADCC9-CC5A-479D-8A7C-38FF4DB78A55@gridcentric.ca>
2012-01-12 19:22 ` Andres Lagar-Cavilla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205113316.GA29024@aepfle.de \
--to=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.