From: Flavio Leitner <fbl@redhat.com>
To: Michael Wang <wangyun@linux.vnet.ibm.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
davem@davemloft.net, netdev@vger.kernel.org, gospo@redhat.com,
sassmann@redhat.com
Subject: Re: [net-next 1/6] e1000e: Avoid wrong check on TX hang
Date: Mon, 5 Dec 2011 11:49:56 -0200 [thread overview]
Message-ID: <20111205114956.439c00bc@asterix.rh> (raw)
In-Reply-To: <4EDC82AE.40806@linux.vnet.ibm.com>
On Mon, 05 Dec 2011 16:37:02 +0800
Michael Wang <wangyun@linux.vnet.ibm.com> wrote:
> Hi, Jeff
>
> Please reserve "From: Michael Wang <wangyun@linux.vnet.ibm.com>" in
> content. And because Flavio not respond these days, I add his name
> for him.
>
> Thanks,
> Michael Wang
>
> On 12/05/2011 04:20 PM, Jeff Kirsher wrote:
>
> > Based on the original patch submitted my Michael Wang
> > <wangyun@linux.vnet.ibm.com>.
>
> From: Michael Wang <wangyun@linux.vnet.ibm.com>
>
> > Descriptors may not be write-back while checking TX hang with flag
> > FLAG2_DMA_BURST on.
> > So when we detect hang, we just flush the descriptor and detect
> > again for once.
> >
> > -v2 change 1 to true and 0 to false and remove extra ()
> >
> > CC: Michael Wang <wangyun@linux.vnet.ibm.com>
> > CC: Flavio Leitner <fbl@redhat.com>
>
> Signed-off-by: Michael Wang <wangyun@linux.vnet.ibm.com>
Agree with the fixes. thanks,
Signed-off-by: Flavio Leitner <fbl@redhat.com>
next prev parent reply other threads:[~2011-12-05 13:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 8:20 [net-next 0/6 v2][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2011-12-05 8:20 ` [net-next 1/6] e1000e: Avoid wrong check on TX hang Jeff Kirsher
2011-12-05 8:37 ` Michael Wang
2011-12-05 13:49 ` Flavio Leitner [this message]
2011-12-05 8:20 ` [net-next 2/6] e1000e: hitting BUG_ON() from napi_enable Jeff Kirsher
2011-12-05 8:20 ` [net-next 3/6] igb: Update DMA Coalescing threshold calculation Jeff Kirsher
2011-12-05 8:20 ` [net-next 4/6] ixgbe: DCBnl set_all, order of operations fix Jeff Kirsher
2011-12-05 8:20 ` [net-next 5/6] ixgbe: DCB: IEEE transitions may fail to reprogram hardware Jeff Kirsher
2011-12-05 8:20 ` [net-next 6/6] ixgbe: Remove function prototype for non-existent function Jeff Kirsher
2011-12-05 23:45 ` [net-next 0/6 v2][pull request] Intel Wired LAN Driver Updates David Miller
-- strict thread matches above, loose matches on Subject: below --
2011-12-03 11:44 [net-next 0/6][pull " Jeff Kirsher
2011-12-03 11:44 ` [net-next 1/6] e1000e: Avoid wrong check on TX hang Jeff Kirsher
2011-12-04 3:26 ` David Miller
2011-12-04 7:28 ` Jeff Kirsher
2011-12-05 1:05 ` Michael Wang
2011-12-05 6:25 ` Jeff Kirsher
2011-12-05 7:15 ` Michael Wang
2011-12-05 8:02 ` Jeff Kirsher
2011-12-05 8:18 ` Michael Wang
2011-12-05 8:24 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205114956.439c00bc@asterix.rh \
--to=fbl@redhat.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=wangyun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.