From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH 3/3] libxl: Introduce migrate with the new
 QEMU.
Date: Mon, 5 Dec 2011 19:16:53 +0100
Message-ID: <20111205181652.GA31962@aepfle.de>
References: <1322070039-439-1-git-send-email-anthony.perard@citrix.com>
	<1322070039-439-4-git-send-email-anthony.perard@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <1322070039-439-4-git-send-email-anthony.perard@citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Xen Devel <xen-devel@lists.xensource.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, Nov 23, Anthony PERARD wrote:

> +    case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
> +        fd2 = open(filename, O_WRONLY | O_CREAT | O_TRUNC);

I havent checked wether automated testing caught this, but:

In function 'open',
    inlined from 'libxl__domain_save_device_model' at libxl_dom.c:630:
/usr/include/bits/fcntl2.h:51: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT in second argument needs 3 arguments
make[3]: *** [libxl_dom.o] Error 1

Olaf