All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	stable@vger.kernel.org, Andrew Vagin <avagin@openvz.org>
Subject: [PATCH 5/6] perf: Fix parsing of __print_flags() in TP_printk()
Date: Mon, 05 Dec 2011 20:41:15 -0500	[thread overview]
Message-ID: <20111206014224.614543275@goodmis.org> (raw)
In-Reply-To: 20111206014110.079874115@goodmis.org

[-- Attachment #1: Type: text/plain, Size: 1128 bytes --]

From: Steven Rostedt <srostedt@redhat.com>

A update is made to the sched:sched_switch event that adds some
logic to the first parameter of the __print_flags() that shows the
state of tasks. This change cause perf to fail parsing the flags.

A simple fix is needed to have the parser be able to process ops
within the argument.

Cc: stable@vger.kernel.org
Reported-by: Andrew Vagin <avagin@openvz.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 tools/perf/util/trace-event-parse.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/tools/perf/util/trace-event-parse.c b/tools/perf/util/trace-event-parse.c
index 0a7ed5b..6c164dc 100644
--- a/tools/perf/util/trace-event-parse.c
+++ b/tools/perf/util/trace-event-parse.c
@@ -1537,6 +1537,8 @@ process_flags(struct event *event, struct print_arg *arg, char **tok)
 	field = malloc_or_die(sizeof(*field));
 
 	type = process_arg(event, field, &token);
+	while (type == EVENT_OP)
+		type = process_op(event, field, &token);
 	if (test_type_token(type, token, EVENT_DELIM, ","))
 		goto out_free;
 
-- 
1.7.7.3



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2011-12-06  1:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-06  1:41 [PATCH 0/6] [GIT PULL][v3.2] tracing: fixes Steven Rostedt
2011-12-06  1:41 ` [PATCH 1/6] tracing: fix event_subsystem ref counting Steven Rostedt
2011-12-06  1:41 ` [PATCH 2/6] tracing: Restore system filter behavior Steven Rostedt
2011-12-06  1:41 ` [PATCH 3/6] ftrace: Remove force undef config value left for testing Steven Rostedt
2011-12-06  1:41 ` [PATCH 4/6] jump_label: jump_label_inc may return before the code is patched Steven Rostedt
2011-12-06  1:41 ` Steven Rostedt [this message]
2011-12-06  1:41 ` [PATCH 6/6] ftrace: Fix hash record accounting bug Steven Rostedt
2011-12-06  5:43 ` [PATCH 0/6] [GIT PULL][v3.2] tracing: fixes Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111206014224.614543275@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=avagin@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.