All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Stefan Ringel <linuxtv@stefanringel.de>,
	linux-media@vger.kernel.org, d.belimov@gmail.com
Subject: Re: [PATCH 3/5] tm6000: bugfix interrupt reset
Date: Tue, 6 Dec 2011 09:12:00 +0100	[thread overview]
Message-ID: <20111206081200.GA8756@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <20111206065119.GA26724@avionic-0098.mockup.avionic-design.de>

[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]

* Thierry Reding wrote:
> * Mauro Carvalho Chehab wrote:
> > That means that all we need is to get rid of TM6000_QUIRK_NO_USB_DELAY.
> 
> I've just reviewed my patches again and it seems that no-USB-delay quirk
> patch was only partially applied. The actual location where it was introduced
> was in tm6000_read_write_usb() to allow the msleep(5) to be skipped, which on
> some devices isn't required and significantly speeds up firmware upload. So I
> don't think we should get rid of it.
> 
> If it helps I can rebase the code against your branch (which one would that
> be exactly?) and resend the rest of the series.

Looking more closely, I think my original patch was applied wrongly. If you
look at the original patch:

	http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/37552

and look at the applied version in this commit:

	42845708363fc92a190f5c47e6fe750e3919f867

Then you see that the hunk from the tm6000_read_write_usb() function was
applied to the tm6000_reset() function instead.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2011-12-06  8:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1322509580-14460-1-git-send-email-linuxtv@stefanringel.de>
2011-11-28 19:46 ` [PATCH 2/5] tm6000: bugfix register setting linuxtv
2011-11-28 19:46 ` [PATCH 3/5] tm6000: bugfix interrupt reset linuxtv
2011-12-05  7:21   ` Thierry Reding
2011-12-05 12:04     ` Mauro Carvalho Chehab
2011-12-05 15:38       ` Thierry Reding
2011-12-05 18:21         ` Mauro Carvalho Chehab
2011-12-05 20:02           ` Stefan Ringel
2011-12-05 20:16             ` Mauro Carvalho Chehab
2011-12-06  6:51               ` Thierry Reding
2011-12-06  8:12                 ` Thierry Reding [this message]
2011-12-06 12:25                   ` Mauro Carvalho Chehab
2011-12-06 13:05                     ` [PATCH] [media] tm6000: Fix fast USB access quirk Thierry Reding
2011-12-06 12:22                 ` [PATCH 3/5] tm6000: bugfix interrupt reset Mauro Carvalho Chehab
2011-11-28 19:46 ` [PATCH 4/5] tm6000: bugfix bulk transfer linuxtv
2011-11-28 19:46 ` [PATCH 5/5] tm6000: bugfix data check linuxtv
2011-11-30 17:21   ` Mauro Carvalho Chehab
2011-12-06 13:39 ` [PATCH 1/2] [media] tm6000: Fix check for interrupt endpoint Thierry Reding
2011-12-06 13:39   ` [PATCH 2/2] [media] tm6000: Fix bad indentation Thierry Reding
2011-12-06 13:58     ` Antti Palosaari
2011-12-06 14:13       ` Thierry Reding
2011-12-06 20:58         ` Mauro Carvalho Chehab
2011-12-06 21:03           ` Antti Palosaari
2011-12-07 13:24             ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111206081200.GA8756@avionic-0098.mockup.avionic-design.de \
    --to=thierry.reding@avionic-design.de \
    --cc=d.belimov@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linuxtv@stefanringel.de \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.