From: Dan Carpenter <dan.carpenter@oracle.com>
To: Olivier Grenie <Olivier.Grenie@dibcom.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [media] dib7090: add the reference board TFE7090E
Date: Tue, 6 Dec 2011 14:00:55 +0300 [thread overview]
Message-ID: <20111206110055.GF3374@mwanda> (raw)
In-Reply-To: <57C38DA176A0A34A9B9F3CCCE33D3C4A01686D86AB9F@FRPAR1CL009.coe.adi.dibcom.com>
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
On Tue, Dec 06, 2011 at 11:13:19AM +0100, Olivier Grenie wrote:
> Dear Dan,
> Indeed, after the "if (state->rf_ramp == NULL)" test, the function
> dib0090_set_rframp_pwm will set the state->rf_ramp. So after this
> line, state->rf_ramp can not be NULL.
>
Ah right. I should have seen that myself.
> But I can make a patch in order to make sure that this code will
> not be detected as an error.
Don't do that if you don't want to. This is fixable on the static
checker side of things.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-12-06 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 7:21 [media] dib7090: add the reference board TFE7090E Dan Carpenter
2011-12-06 10:13 ` Olivier Grenie
2011-12-06 11:00 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206110055.GF3374@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Olivier.Grenie@dibcom.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.