From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: David Ahern <dsahern@gmail.com>
Cc: Andrew Vagin <avagin@openvz.org>,
linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
paulus@samba.org, mingo@elte.hu, asharma@fb.com,
devel@openvz.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 3/7] perf: add ability to change event according to sample (v2)
Date: Tue, 6 Dec 2011 13:06:23 -0200 [thread overview]
Message-ID: <20111206150623.GG10709@infradead.org> (raw)
In-Reply-To: <4EDE2D62.9050802@gmail.com>
Em Tue, Dec 06, 2011 at 07:57:38AM -0700, David Ahern escreveu:
> Ditto on that comment.
>
> I did not test it, but the logic is in the inverse of parse_sample so it
> should be correct.
>
> Arnaldo: you could use remove the 2 comment lines on the commit since
> there are no logic impacts.
>
> Reviewed-by: David Ahern <dsahern@gmail.com>
Thanks, will do that,
- Arnaldo
next prev parent reply other threads:[~2011-12-06 15:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 9:03 [PATCH 0/7] Profiling sleep times (v3) Andrew Vagin
2011-11-28 9:03 ` [PATCH 1/7] perf: use event_name() to get an event name Andrew Vagin
2011-12-06 14:02 ` Arnaldo Carvalho de Melo
2011-12-08 4:34 ` [tip:perf/urgent] perf header: Use " tip-bot for Andrew Vagin
2011-11-28 9:03 ` [PATCH 2/7] perf: add ability to record event period Andrew Vagin
2011-12-06 14:02 ` Arnaldo Carvalho de Melo
2011-11-28 9:03 ` [PATCH 3/7] perf: add ability to change event according to sample (v2) Andrew Vagin
2011-12-06 14:19 ` Arnaldo Carvalho de Melo
2011-12-06 14:24 ` Arnaldo Carvalho de Melo
2011-12-06 14:57 ` David Ahern
2011-12-06 15:06 ` Arnaldo Carvalho de Melo [this message]
2011-11-28 9:03 ` [PATCH 4/7] perf: teach "perf inject" to work with files Andrew Vagin
2011-11-28 9:03 ` [PATCH 5/7] perf: teach perf inject to merge sched_stat_* and sched_switch events Andrew Vagin
2011-11-28 9:03 ` [PATCH 6/7] perf: add scripts for profiling sleep times (v2) Andrew Vagin
2011-11-28 9:03 ` [PATCH 7/7] event: add tracepoint for accounting block time Andrew Vagin
2011-11-28 11:42 ` Peter Zijlstra
2011-11-28 14:02 ` Arjan van de Ven
2011-11-28 14:31 ` Arnaldo Carvalho de Melo
2011-11-28 14:43 ` Arjan van de Ven
2011-11-28 14:59 ` Arnaldo Carvalho de Melo
2011-12-06 9:48 ` [tip:sched/core] events, sched: Add tracepoint for accounting blocked time tip-bot for Andrew Vagin
2011-12-06 7:15 ` [Devel] [PATCH 0/7] Profiling sleep times (v3) Andrey Vagin
2011-12-06 8:30 ` Ingo Molnar
2011-12-06 13:45 ` Arnaldo Carvalho de Melo
2011-12-07 20:33 ` Arun Sharma
2011-12-07 20:33 ` Arun Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206150623.GG10709@infradead.org \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=asharma@fb.com \
--cc=avagin@openvz.org \
--cc=devel@openvz.org \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.