From: Greg KH <greg@kroah.com>
To: Shimrit Malichi <smalichi@codeaurora.org>
Cc: linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
balbi@ti.com, ablay@codeaurora.org
Subject: Re: [RFC/PATCH v4 0/3] UAS Gadget Driver.
Date: Tue, 6 Dec 2011 09:09:55 -0800 [thread overview]
Message-ID: <20111206170955.GA28453@kroah.com> (raw)
In-Reply-To: <7f812534b7c8a0162e10b0efd1a02dbf.squirrel@www.codeaurora.org>
On Tue, Dec 06, 2011 at 08:39:58AM -0800, Shimrit Malichi wrote:
>
> > On Sun, Dec 04, 2011 at 10:18:14PM +0200, Shimrit Malichi wrote:
> >> This patch series implements the UAS gadget driver.
> >>
> >> It has been tested using the following:
> >> 1. Linux UAS host driver
> >> 2. Internaly developed unittests framework
> >>
> >> The device is functional. More stress tests are needed.
> >>
> >> TODO: Further testing
> >> De-register the gadget if the main thread dies.
> >
> > What about all of the review comments you seem to be ignoring that have
> > been made for this driver in the past?
> >
> > greg k-h
> >
> We addressed most of the comments. One of them was indeed to use the
> target framework, however when we asked an additional information about
> how to use this framework we didn't get a detailed reply. Sebastian gave
> an answer on how to use it yesterday. We will study his answer, and come
> up with a new code.
No one is going to normally give you such a detailed answer as he did.
You were told to go use that interface, and Sebastian did just that, why
couldn't you have done that in the first place, saving you, and everyone
else here, time and effort of telling you to go do that again?
greg k-h
next prev parent reply other threads:[~2011-12-06 17:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-04 20:18 [RFC/PATCH v4 0/3] UAS Gadget Driver Shimrit Malichi
[not found] ` <1323029894-16106-1-git-send-email-smalichi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-12-05 15:55 ` Greg KH
2011-12-06 16:39 ` Shimrit Malichi
2011-12-06 17:09 ` Greg KH [this message]
2011-12-07 8:39 ` Felipe Balbi
2011-12-07 17:34 ` Shimrit Malichi
[not found] ` <dbceef1c27984ec023a409618d25504c.squirrel-mMfbam+mt9083fI46fginR2eb7JE58TQ@public.gmane.org>
2011-12-08 17:37 ` Sebastian Andrzej Siewior
2011-12-21 14:05 ` Shimrit Malichi
2011-12-21 14:27 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206170955.GA28453@kroah.com \
--to=greg@kroah.com \
--cc=ablay@codeaurora.org \
--cc=balbi@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=smalichi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.