From: Oleg Nesterov <oleg@redhat.com>
To: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Cc: rjw@sisk.pl, pavel@ucw.cz, len.brown@intel.com, tj@kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/2] PM / Freezer: Remove the "userspace only" constraint from freezer[_do_not]_count()
Date: Tue, 6 Dec 2011 18:20:20 +0100 [thread overview]
Message-ID: <20111206172020.GA709@redhat.com> (raw)
In-Reply-To: <20111206160251.16729.62719.stgit@srivatsabhat.in.ibm.com>
On 12/06, Srivatsa S. Bhat wrote:
>
> And moreover, even the vfork issue does not need
> the above restriction in these functions, since they are anyway called by
> userspace processes.
This looks a bit confusing, as if CLONE_VFORK is not used by kthreads.
It is actually used, but only by the non-freezeable workqueue threads,
so the patch is fine.
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2011-12-06 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 16:03 [PATCH 1/2] PM / Freezer: Remove the "userspace only" constraint from freezer[_do_not]_count() Srivatsa S. Bhat
2011-12-06 16:04 ` [PATCH 2/2] PM: Use the freezer_count() functions in [un]lock_system_sleep() APIs Srivatsa S. Bhat
2011-12-06 16:35 ` Tejun Heo
2011-12-06 16:35 ` [PATCH 1/2] PM / Freezer: Remove the "userspace only" constraint from freezer[_do_not]_count() Tejun Heo
2011-12-06 17:20 ` Oleg Nesterov [this message]
2011-12-06 18:11 ` Srivatsa S. Bhat
2011-12-06 22:36 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206172020.GA709@redhat.com \
--to=oleg@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.