From: Olaf Hering <olaf@aepfle.de>
To: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Cc: andres@gridcentric.ca, xen-devel@lists.xensource.com,
tim@xen.org, keir.xen@gmail.com, adin@gridcentric.ca
Subject: Re: [PATCH 0 of 2] Mem event ring management overhaul
Date: Tue, 6 Dec 2011 18:26:05 +0100 [thread overview]
Message-ID: <20111206172605.GA18176@aepfle.de> (raw)
In-Reply-To: <patchbomb.1323098647@xdev.gridcentric.ca>
On Mon, Dec 05, Andres Lagar-Cavilla wrote:
> Ensure no guest events are ever lost in the mem event ring.
>
> This is one of two outstanding proposals to solve this issue. One
> key difference between them being that ours does not necessitate wait
> queues.
>
> Instead, we rely on foreign domain retry (already in place), preempting
> hypercalls that may cause unbounded guest events (such as
> decrease_reservation), and ensuring there is always space left in the
> ring for each guest vcpu to place at least one event.
Thats not enough. Cases like hvm_copy and the emulator do currently no
retry, instead they get an invalid mfn and crash the guest. Its possible
to code around that in some places, like shown in the URL below, but
wouldnt it make sense to just stop execution until the expected
condition is met?
Its not clear to me how to properly handle a full ring in
get_gfn_type_access() with your proposal.
Olaf
http://old-list-archives.xen.org/archives/html/xen-devel/2011-01/msg01121.html
next prev parent reply other threads:[~2011-12-06 17:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 15:24 [PATCH 0 of 2] Mem event ring management overhaul Andres Lagar-Cavilla
2011-12-05 15:24 ` [PATCH 1 of 2] Allow decrease_reservation to be preempted if remove_page returns negative Andres Lagar-Cavilla
2011-12-06 9:48 ` Jan Beulich
2011-12-05 15:24 ` [PATCH 2 of 2] Improve ring management for memory events. Do not lose guest events Andres Lagar-Cavilla
2011-12-06 17:26 ` Olaf Hering [this message]
2011-12-06 17:43 ` [PATCH 0 of 2] Mem event ring management overhaul Andres Lagar-Cavilla
2011-12-07 13:17 ` Olaf Hering
2011-12-07 16:26 ` Andres Lagar-Cavilla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206172605.GA18176@aepfle.de \
--to=olaf@aepfle.de \
--cc=adin@gridcentric.ca \
--cc=andres@gridcentric.ca \
--cc=andres@lagarcavilla.org \
--cc=keir.xen@gmail.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.