From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] switch routing algorithm at runtime
Date: Tue, 6 Dec 2011 18:36:45 +0100 [thread overview]
Message-ID: <20111206173645.GA17017@pandem0nium> (raw)
In-Reply-To: <201112062330.54377.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 2058 bytes --]
Hey there,
On Tue, Dec 06, 2011 at 11:30:54PM +0800, Marek Lindner wrote:
>
> Hi,
>
> > When it is in debugfs, it implies that the user has no choice, it is a
> > debug tool only. So when the development is finished, one day batman
> > will just swap from IV to V, and the user gets no choice?
> >
> > For the moment, i think it is O.K. in debugfs. However, there should
> > be some sort of idea how this is going to work when it comes to
> > actually mainstream use of V. Is it simply that IV is dead, you need
> > to use V now. Or do we give the user a choice and some file under /sys
> > to make this choice?
>
> the idea of using debugfs instead of sysfs was to avoid the chicken & egg
> problem (I guess). However, looking at my batman-adv debugfs entry tells me
> that we have the same problem there. Unless we want to move this file into the
> debugfs batman-adv root folder (/sys/kernel/debug/batman_adv) we can't move
> forward either. The whole init/config structure has been designed for "create
> bat0 first".
>
> If we don't want to rewrite this whole part I only see 2 options:
> * compile or module parameter
> * changing the routing algo on the fly
Yeah, we would have to move it into /sys/kernel/debug/batman_adv in the root,
but Andrew may be right about future "non-debug" algorithm selection.
Maybe we go back to Antonios idea with the module parameter, but make it
changeable in runtime. Haven't done that yet, but it seems to be possible [1]:
''Loadable modules, after being loaded into the running kernel, also
reveal their parameters in /sys/module/${modulename}/parameters/. Some of these
parameters may be changed at runtime by the command
"echo -n ${value} > /sys/module/${modulename}/parameters/${parm}" ''
The rest would work as described: having a default value, allow user
changes in runtime and use the configured algorithm value for the next
soft interface creation.
How about this?
Simon
[1] http://www.kernel.org/doc/Documentation/kernel-parameters.txt
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2011-12-06 17:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 9:56 [B.A.T.M.A.N.] switch routing algorithm at runtime Marek Lindner
2011-12-05 9:56 ` [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: add infrastructure to change " Marek Lindner
2011-12-05 9:56 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: convert batman iv algorithm to use dynamic infrastructure Marek Lindner
2011-12-05 9:56 ` [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: allowing changing the routing algorithm via sysfs Marek Lindner
2011-12-05 11:27 ` [B.A.T.M.A.N.] switch routing algorithm at runtime Andrew Lunn
2011-12-05 11:35 ` Marek Lindner
2011-12-05 12:13 ` Andrew Lunn
2011-12-05 13:38 ` Marek Lindner
2011-12-05 14:09 ` Antonio Quartulli
2011-12-05 14:38 ` Andrew Lunn
2011-12-05 14:44 ` Antonio Quartulli
2011-12-05 14:25 ` Andrew Lunn
2011-12-06 15:01 ` Simon Wunderlich
2011-12-06 15:06 ` Antonio Quartulli
2011-12-06 15:21 ` Andrew Lunn
2011-12-06 15:30 ` Marek Lindner
2011-12-06 17:36 ` Simon Wunderlich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206173645.GA17017@pandem0nium \
--to=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.