All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@redhat.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org, Mike Galbraith <efault@gmx.de>,
	Paul Turner <pjt@google.com>,
	Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH 0/3] Use jump_label for sched_feat()
Date: Tue, 6 Dec 2011 13:10:01 -0500	[thread overview]
Message-ID: <20111206181000.GE2449@redhat.com> (raw)
In-Reply-To: <20111206171534.429636558@chello.nl>

On Tue, Dec 06, 2011 at 06:15:34PM +0100, Peter Zijlstra wrote:
> These patches implement sched_feat() using jump_labels. The first is a section
> mismatch fix. The second patch provides a little infrastructure and the third
> patch applies it to make sched_feat() use static_branch().
> 
> It uses static_branch() coupled with unlikely/likely in order to control the
> branch block position. I haven't checked if it works, but it likely doesn't,
> although it should.
> 
> 

It doesn't. I played around with unlikely/likely a bit, and it
didn't seem to make a difference. That said, jump_labels could still be
an improvement here - it be good if we had some numbers, I guess.

Thanks,

-Jason

  parent reply	other threads:[~2011-12-06 19:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-06 17:15 [PATCH 0/3] Use jump_label for sched_feat() Peter Zijlstra
2011-12-06 17:15 ` [PATCH 1/3] jump_label, x86: Fix section mismatch Peter Zijlstra
2011-12-06 17:15 ` [PATCH 2/3] sched: Fix compile error for UP,!NOHZ Peter Zijlstra
2011-12-06 17:35   ` Peter Zijlstra
2011-12-06 17:15 ` [PATCH 3/3] sched: Use jump_labels for sched_feat Peter Zijlstra
2011-12-06 18:10 ` Jason Baron [this message]
2011-12-06 19:12   ` [PATCH 0/3] Use jump_label for sched_feat() Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111206181000.GE2449@redhat.com \
    --to=jbaron@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@infradead.org \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pjt@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.