From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 2/5] revert: make commit subjects in insn sheet optional
Date: Wed, 7 Dec 2011 01:02:24 -0600 [thread overview]
Message-ID: <20111207070223.GC11737@elie.hsd1.il.comcast.net> (raw)
In-Reply-To: <1323239877-24101-3-git-send-email-artagnon@gmail.com>
Ramkumar Ramachandra wrote:
> Change the instruction sheet format subtly so that the subject of the
> commit message that follows the object name is optional. As a result,
> an instruction sheet like this is now perfectly valid:
>
> pick 35b0426
> pick fbd5bbcbc2e
> pick 7362160f
>
> While at it, also fix a bug: currently, we use a commit-id-shaped
> buffer to store the word after "pick" in '.git/sequencer/todo'. This
> is both wasteful and wrong because it places an artificial limit on
> the line length. Eliminate the need for the buffer altogether, and
> add a test demonstrating this.
>
> [jc: simplify parsing]
Reading the above does not make it at all obvious that I should want
to apply this patch because otherwise my prankster friend can cause my
copy of git to crash or run arbitrary code by putting a long commit
name in .git/sequencer/todo in our NFS-mounted shared checkout.
(Yes, I know there are other problems with such a setup, especially if
.git/hooks or .git/config is writable by untrusted people. So it is
not actually a security bug, but a robustness one.)
next prev parent reply other threads:[~2011-12-07 7:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 6:37 [PATCH 0/5] Re-roll rr/revert-cherry-pick Ramkumar Ramachandra
2011-12-07 6:37 ` [PATCH 1/5] revert: free msg in format_todo() Ramkumar Ramachandra
2011-12-07 6:43 ` Jonathan Nieder
2011-12-07 6:37 ` [PATCH 2/5] revert: make commit subjects in insn sheet optional Ramkumar Ramachandra
2011-12-07 7:02 ` Jonathan Nieder [this message]
2011-12-09 5:57 ` Ramkumar Ramachandra
2011-12-09 6:12 ` Ramkumar Ramachandra
2011-12-09 19:35 ` Jonathan Nieder
2011-12-09 19:44 ` Ramkumar Ramachandra
2011-12-09 19:50 ` Jonathan Nieder
2011-12-09 22:30 ` Ramkumar Ramachandra
2011-12-07 6:37 ` [PATCH 3/5] revert: simplify getting commit subject in format_todo() Ramkumar Ramachandra
2011-12-07 7:06 ` Jonathan Nieder
2011-12-07 6:37 ` [PATCH 4/5] revert: allow mixed pick and revert instructions Ramkumar Ramachandra
2011-12-07 7:45 ` Jonathan Nieder
2011-12-09 5:34 ` Ramkumar Ramachandra
2011-12-07 6:37 ` [PATCH 5/5] revert: simplify communicating command-line arguments Ramkumar Ramachandra
2011-12-07 8:09 ` Jonathan Nieder
2011-12-07 8:17 ` [PATCH 0/5] Re-roll rr/revert-cherry-pick Jonathan Nieder
2011-12-07 8:26 ` Ramkumar Ramachandra
2011-12-07 9:56 ` Jonathan Nieder
2011-12-07 8:28 ` Jonathan Nieder
2011-12-08 18:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207070223.GC11737@elie.hsd1.il.comcast.net \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.