From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nadav Har'El Subject: Re: [PATCH 02/10] nEPT: MMU context for nested EPT Date: Wed, 7 Dec 2011 11:06:34 +0200 Message-ID: <20111207090634.GA26611@fermat.math.technion.ac.il> References: <1320919040-nyh@il.ibm.com> <201111100958.pAA9wrIv019614@rice.haifa.ibm.com> <4EBBC848.7050400@redhat.com> <20111110144027.GB3327@fermat.math.technion.ac.il> <4EBBEB65.8050600@redhat.com> <20111110200532.GA17475@fermat.math.technion.ac.il> <4EBE4CE0.7070708@redhat.com> <20111112213747.GA741@fermat.math.technion.ac.il> <4EBFAA47.406@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm@vger.kernel.org, "Roedel, Joerg" , abelg@il.ibm.com To: Orit Wasserman Return-path: Received: from mailgw12.technion.ac.il ([132.68.225.12]:5169 "EHLO mailgw12.technion.ac.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753414Ab1LGJGl (ORCPT ); Wed, 7 Dec 2011 04:06:41 -0500 Content-Disposition: inline In-Reply-To: <4EBFAA47.406@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Nov 13, 2011, Orit Wasserman wrote about "Re: [PATCH 02/10] nEPT: MMU context for nested EPT": > +++ b/arch/x86/kvm/mmu.h > @@ -48,6 +48,11 @@ > #define PFERR_RSVD_MASK (1U << 3) > #define PFERR_FETCH_MASK (1U << 4) > > +#define EPT_WRITABLE_MASK 2 > +#define EPT_EXEC_MASK 4 This is another example of the "unclean" movement of VMX-specific things into x86 :( We already have VMX_EPT_WRITABLE_MASK and friends in vmx.h. I'll need to think what is less ugly: to move them to mmu.h, or to include vmx.h in mmu.c, or perhaps even create a new include file, ept.h. Avi, do you have a preference? The last thing I want to do is to repeat the same definitions in two places. -- Nadav Har'El | Wednesday, Dec 7 2011, nyh@math.technion.ac.il |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |"A witty saying proves nothing." -- http://nadav.harel.org.il |Voltaire