From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: make head.S register assignments more convenient
Date: Wed, 7 Dec 2011 11:43:04 +0000 [thread overview]
Message-ID: <20111207114304.GB2910@linaro.org> (raw)
In-Reply-To: <alpine.LFD.2.02.1112061357280.2357@xanadu.home>
On Tue, Dec 06, 2011 at 02:01:23PM -0500, Nicolas Pitre wrote:
> On Tue, 6 Dec 2011, Dave Martin wrote:
>
> > On Tue, Dec 06, 2011 at 11:29:12AM +0000, Russell King - ARM Linux wrote:
> > > On Tue, Dec 06, 2011 at 11:11:05AM +0000, Dave Martin wrote:
> > > > Is it also worth changing the other proc-*.S setup rountines to be PCS
> > > > compliant too? This would clean up the calling convention further, and
> > > > help avoid future sutprises.
> > >
> > > They _aren't_ PCS functions in any case. They don't have a stack
> > > available to them. So, having them as non-PCS functions reinforces
> > > the fact that they _are_ special.
> >
> > Fair point.
> >
> > Maybe a brief note in the commit message explaining why only certain
> > proc-*.S files are touched would be belpful. But it's not vital.
>
> They are touched only because they were using registers where I moved
> the previous r1 and r2 values to. So I moved their usage of mainly
> r5-r6 to the normally callee clobbered registers. I don't think there
> is further changes that would be as badly needed as those I did.
Fair enough
---Dave
prev parent reply other threads:[~2011-12-07 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 20:31 [PATCH] ARM: make head.S register assignments more convenient Nicolas Pitre
2011-12-06 11:11 ` Dave Martin
2011-12-06 11:29 ` Russell King - ARM Linux
2011-12-06 13:23 ` Dave Martin
2011-12-06 19:01 ` Nicolas Pitre
2011-12-07 11:43 ` Dave Martin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207114304.GB2910@linaro.org \
--to=dave.martin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.