From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v2] soc/lapis: add machine driver Date: Wed, 7 Dec 2011 13:23:23 +0000 Message-ID: <20111207132322.GA18837@opensource.wolfsonmicro.com> References: <1322819115-15808-1-git-send-email-tomoya.rohm@gmail.com> <20111202153401.GX8245@opensource.wolfsonmicro.com> <20111205183223.GB7467@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from opensource.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 7A361243AF for ; Wed, 7 Dec 2011 14:24:43 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Tomoya MORINAGA Cc: Dimitris Papastamos , alsa-devel@alsa-project.org, Lars-Peter Clausen , Mike Frysinger , qi.wang@intel.com, Takashi Iwai , linux-kernel@vger.kernel.org, yong.y.wang@intel.com, kok.howg.ewe@intel.com, Daniel Mack , Liam Girdwood , joel.clark@intel.com List-Id: alsa-devel@alsa-project.org On Wed, Dec 07, 2011 at 01:42:45PM +0900, Tomoya MORINAGA wrote: > 2011/12/6 Tomoya MORINAGA : You're complaining that you didn't a response within 24 hours! This is really not reasonable for something which is essentially volunteer driven project. > > You said "Use the dai_fmt field in the dai_link to set this." > > However, both dai_fmt and dai_link are already implemented like below. > > static struct snd_soc_dai_link ioh_i2s_dai =3D { > > static struct snd_soc_card ioh_i2s_card =3D { > > ... > > =A0 =A0 =A0 =A0.dai_link =A0 =A0 =A0 =3D &ioh_i2s_dai, > > ... > > }; > > So, I can't understand your saying. > Could you give me your answer ? Your above code has no references to dai_fmt. Have you looked at the dai_fmt field in the dai_link structure or at the existing examples of its use? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755788Ab1LGNYp (ORCPT ); Wed, 7 Dec 2011 08:24:45 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:43003 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755645Ab1LGNYo (ORCPT ); Wed, 7 Dec 2011 08:24:44 -0500 Date: Wed, 7 Dec 2011 13:23:23 +0000 From: Mark Brown To: Tomoya MORINAGA Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , Dimitris Papastamos , Mike Frysinger , Daniel Mack , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com, kok.howg.ewe@intel.com Subject: Re: [PATCH v2] soc/lapis: add machine driver Message-ID: <20111207132322.GA18837@opensource.wolfsonmicro.com> References: <1322819115-15808-1-git-send-email-tomoya.rohm@gmail.com> <20111202153401.GX8245@opensource.wolfsonmicro.com> <20111205183223.GB7467@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Cookie: You will have long and healthy life. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 07, 2011 at 01:42:45PM +0900, Tomoya MORINAGA wrote: > 2011/12/6 Tomoya MORINAGA : You're complaining that you didn't a response within 24 hours! This is really not reasonable for something which is essentially volunteer driven project. > > You said "Use the dai_fmt field in the dai_link to set this." > > However, both dai_fmt and dai_link are already implemented like below. > > static struct snd_soc_dai_link ioh_i2s_dai = { > > static struct snd_soc_card ioh_i2s_card = { > > ... > >        .dai_link       = &ioh_i2s_dai, > > ... > > }; > > So, I can't understand your saying. > Could you give me your answer ? Your above code has no references to dai_fmt. Have you looked at the dai_fmt field in the dai_link structure or at the existing examples of its use?