From: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211: Fix race in bss timeout
Date: Wed, 7 Dec 2011 21:23:27 +0530 [thread overview]
Message-ID: <20111207155325.GC12498@chvasanth-lnx> (raw)
In-Reply-To: <1323272248.3404.43.camel@jlt3.sipsolutions.net>
On Wed, Dec 07, 2011 at 04:37:28PM +0100, Johannes Berg wrote:
> >
> > These warnings are added in cfg80211_roamed().
>
> But this can be called directly by the driver with a NULL BSS.
>
> Ohh. I see what you did, you didn't allow drivers calling this now. I
> think you should export this function still since otherwise the race
> windows might get tiny, but isn't actually completely closed (the first
> get_bss() might find it, the next a millisecond later not)
I can understand the millisecond delay between cfg80211_get_bss() in driver and
__cfg80211_roamed() as there can be delay in event_work getting
scheduled. I don't understand the delay between driver and
cfg80211_roamed() as the later one is direct call. Or this can be
done later if experienced the delay?.
Vasanth
next prev parent reply other threads:[~2011-12-07 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 15:11 [PATCH] cfg80211: Fix race in bss timeout Vasanthakumar Thiagarajan
2011-12-07 15:17 ` Johannes Berg
2011-12-07 15:30 ` Vasanthakumar Thiagarajan
2011-12-07 15:37 ` Johannes Berg
2011-12-07 15:53 ` Vasanthakumar Thiagarajan [this message]
2011-12-07 15:56 ` Johannes Berg
2011-12-07 16:03 ` Vasanthakumar Thiagarajan
2011-12-08 8:33 ` Vasanthakumar Thiagarajan
2011-12-08 8:38 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207155325.GC12498@chvasanth-lnx \
--to=vthiagar@qca.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.