From: Tony Lindgren <tony@atomide.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Heikki Krogerus <krohei@gmail.com>,
Felipe Contreras <felipe.contreras@nokia.com>,
linux-main <linux-kernel@vger.kernel.org>,
Kalle Jokiniemi <kalle.jokiniemi@nokia.com>,
Anton Vorontsov <cbouatmailru@gmail.com>
Subject: Re: [PATCH 2/2] Revert "ARM: RX-51: Enable isp1704 power on/off"
Date: Wed, 7 Dec 2011 11:31:42 -0800 [thread overview]
Message-ID: <20111207193141.GG31337@atomide.com> (raw)
In-Reply-To: <CAMP44s2FV=Dtquq+HuhB7+0fTi9YwiY-4YcSf1XdB=OwDHYULA@mail.gmail.com>
* Felipe Contreras <felipe.contreras@gmail.com> [111207 10:12]:
> On Wed, Dec 7, 2011 at 3:05 PM, Heikki Krogerus <krohei@gmail.com> wrote:
> > On Mon, Dec 05, 2011 at 07:23:40PM +0200, Felipe Contreras wrote:
> >> From: Felipe Contreras <felipe.contreras@gmail.com>
> >>
> >> This reverts commit 10299e2e4e3ed3b16503d4e04edd48b33083f4e2.
> >>
> >> This seems to break USB networking stuff.
> >>
> >> Cc: Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
> >> Cc: Heikki Krogerus <heikki.krogerus@nokia.com>
> >> Cc: Anton Vorontsov <cbouatmailru@gmail.com>
> >> Cc: Tony Lindgren <tony@atomide.com>
> >> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> >> ---
> >> arch/arm/mach-omap2/board-rx51-peripherals.c | 27 +------------------------
> >> 1 files changed, 2 insertions(+), 25 deletions(-)
> >
> > <snip>
> >
> >> -static void __init rx51_charger_init(void)
> >> -{
> >> - WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO,
> >> - GPIOF_OUT_INIT_LOW, "isp1704_reset"));
> >
> > How about simply GPIOF_OUT_INIT_HIGH here. Is that not enough to fix
> > your problem? Revering the whole thing does not make any sense to me.
>
> Yes, that fixes it :)
Got an updated patch for this one? Please also Cc linux-omap and
linux-arm-kernel lists for arch/arm/*omap*/ touching patches.
Regards,
Tony
next prev parent reply other threads:[~2011-12-07 19:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 17:23 [PATCH 0/2] omap: rx51: fix USB networking Felipe Contreras
2011-12-05 17:23 ` [PATCH 1/2] isp1704_charger: fix missing check Felipe Contreras
2011-12-08 14:42 ` Heikki Krogerus
2012-01-06 2:02 ` Anton Vorontsov
2011-12-05 17:23 ` [PATCH 2/2] Revert "ARM: RX-51: Enable isp1704 power on/off" Felipe Contreras
2011-12-05 17:31 ` Felipe Contreras
2011-12-07 11:46 ` Jarkko Nikula
2011-12-07 18:42 ` Felipe Contreras
2011-12-12 7:09 ` Jarkko Nikula
2011-12-13 21:19 ` Felipe Contreras
2011-12-13 22:53 ` Felipe Balbi
2011-12-13 23:02 ` Felipe Contreras
2011-12-14 7:30 ` Felipe Balbi
2011-12-14 19:31 ` Felipe Contreras
2011-12-07 7:14 ` kalle.jokiniemi
2011-12-07 10:57 ` Felipe Contreras
2011-12-07 13:05 ` Heikki Krogerus
2011-12-07 18:43 ` Felipe Contreras
2011-12-07 19:31 ` Tony Lindgren [this message]
2011-12-07 19:56 ` [PATCH] omap: rx51: initialize isp1704 properly Felipe Contreras
2011-12-07 19:56 ` Felipe Contreras
2011-12-08 14:40 ` Heikki Krogerus
2011-12-08 14:40 ` Heikki Krogerus
2011-12-08 20:23 ` [PATCH v2] omap: rx51: fix USB Felipe Contreras
2011-12-08 20:23 ` Felipe Contreras
2011-12-10 8:37 ` Sebastian Reichel
2011-12-10 8:37 ` Sebastian Reichel
2011-12-08 20:23 ` [PATCH] omap: rx51: initialize isp1704 properly Felipe Contreras
2011-12-08 20:23 ` Felipe Contreras
2011-12-12 19:44 ` Tony Lindgren
2011-12-12 19:44 ` Tony Lindgren
2011-12-13 20:00 ` Sebastian Reichel
2011-12-13 20:00 ` Sebastian Reichel
2011-12-13 20:05 ` Felipe Contreras
2011-12-13 20:05 ` Felipe Contreras
2011-12-13 21:55 ` Tony Lindgren
2011-12-13 21:55 ` Tony Lindgren
2011-12-08 14:13 ` [PATCH 2/2] Revert "ARM: RX-51: Enable isp1704 power on/off" Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207193141.GG31337@atomide.com \
--to=tony@atomide.com \
--cc=cbouatmailru@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=felipe.contreras@nokia.com \
--cc=kalle.jokiniemi@nokia.com \
--cc=krohei@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.