From: Stephen Hemminger <shemminger@vyatta.com>
To: Ted Feng <artisdom@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jiri Pirko <jpirko@redhat.com>, Josh Boyer <jwboyer@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipip, sit: copy parms.name after register_netdevice
Date: Wed, 7 Dec 2011 20:16:10 -0800 [thread overview]
Message-ID: <20111207201610.7cc9714a@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <CAM7b5hyXkRTUwnE-NwXEff-34WjRfMSBDf2itMVhdJGi4XoA=g@mail.gmail.com>
On Thu, 8 Dec 2011 11:35:15 +0800
Ted Feng <artisdom@gmail.com> wrote:
> From: Ted Feng <artisdom@gmail.com>
> Same fix as 731abb9cb2 for ipip and sit tunnel.
> Commit 1c5cae815d removed an explicit call to dev_alloc_name in
> ipip_tunnel_locate and ipip6_tunnel_locate, because register_netdevice
> will now create a valid name. However the tunnel keeps a copy of the
> name in the private parms structure.
>
> This shows up if you do a simple tunnel add, followed by a tunnel show:
>
Ok, but keeping a private copy is not a good idea, since tunnel
can be renamed.
ip li set dev tun0 name tunnel-of-love
next prev parent reply other threads:[~2011-12-08 4:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 9:25 [PATCH] ipip, sit: copy parms.name after register_netdevice Ted Feng
2011-12-06 17:32 ` Greg KH
2011-12-08 3:35 ` Ted Feng
2011-12-08 4:16 ` Stephen Hemminger [this message]
2011-12-08 4:56 ` David Miller
2011-12-08 10:46 ` Ted Feng
2011-12-10 14:29 ` Ted Feng
2011-12-10 18:12 ` David Miller
2011-12-12 23:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207201610.7cc9714a@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=artisdom@gmail.com \
--cc=davem@davemloft.net \
--cc=jpirko@redhat.com \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.