From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ne2000: Convert to new net-multi model, fixes build of three boards
Date: Wed, 7 Dec 2011 22:45:57 +0100 [thread overview]
Message-ID: <201112072245.58008.marek.vasut@gmail.com> (raw)
In-Reply-To: <1319144219-15731-1-git-send-email-bernhard.kaindl@gmx.net>
> This fixes the build of the two sh boards shmin and r7780mp and qemu-mips
> which currently fail to build due to dropped pre-CONFIG_NET_MULTI code.
>
> This v2 patch minimizes the number of lines in the diff for easy review
> and to eliminate any possible accidential changes resulting from moving
> lines of code in the file. This also makes the register function very easy.
>
> Any cleanups and improvements are intentionally deferred to follow-up
> patches to keep this patch as simple and as easy to review as possible.
>
> A new driver register function, ne2k_register() calls the existing
> one-time setup part of the old init function and calls eth_register().
>
> Changes to shmin, r7780mp and qemu-mips:
> - Call the new ne2k_register() from board_eth_init() of the boards.
>
> - Tested using qemu-mips board,
> - Tested the two renesas / sh boards r7780mp and shmin to compile again,
> and should work.
>
> checkpatch-clean when "--ignore VOLATILE" is added to .checkpatch.conf,
> and no warnings introduced in none of the three boards using this driver.
>
> Signed-off-by: Bernhard Kaindl <bernhard.kaindl@gmx.net>
> ---
> board/qemu-mips/qemu-mips.c | 6 ++
> board/renesas/r7780mp/r7780mp.c | 3 +-
> board/shmin/shmin.c | 6 ++
> drivers/net/ne2000_base.c | 99
> ++++++++++++++++++++++++++++----------- include/netdev.h |
> 1 +
> 5 files changed, 86 insertions(+), 29 deletions(-)
>
I think this patch is absolutelly essential to have in .12 release. I'll test it
now and ev. rebase and resubmit. Bernhard, you're ok with me doing minor fixes?
M
next prev parent reply other threads:[~2011-12-07 21:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-16 18:12 [U-Boot] [PATCH] ne2000: Fix broken build of three boards after CONFIG_NET_MULTI drop Bernhard Kaindl
2011-10-16 19:39 ` Mike Frysinger
2011-10-17 22:05 ` Bernhard Kaindl
2011-10-17 22:26 ` Mike Frysinger
2011-10-17 22:29 ` Mike Frysinger
2011-10-20 20:56 ` [U-Boot] [PATCH v2] ne2000: Convert to new net-multi model, fixes build of three boards Bernhard Kaindl
2011-12-07 21:45 ` Marek Vasut [this message]
2011-12-08 21:27 ` Wolfgang Denk
2011-12-09 3:47 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112072245.58008.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.