Re: [PATCH v2 3/8] arm/tegra: Split Seaboard GPIO table to allow for Ventana

[Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>]

Hi,

On Wed, Dec 07, 2011 at 03:13:44PM -0700, Stephen Warren wrote:
> Seaboard and Ventana share some GPIOs, but others are different. Split the
> GPIO table into common, seaboard-specific, and ventana-specific tables, so
> that only the correct ones are enabled for each board. Add a few missing
> audio-related GPIOs for Ventana.
> 
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>  arch/arm/mach-tegra/board-seaboard-pinmux.c |   16 +++++++++++++++-
>  1 files changed, 15 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-tegra/board-seaboard-pinmux.c b/arch/arm/mach-tegra/board-seaboard-pinmux.c
> index b1c2972..cb5b2e9 100644
> --- a/arch/arm/mach-tegra/board-seaboard-pinmux.c
> +++ b/arch/arm/mach-tegra/board-seaboard-pinmux.c
> @@ -190,14 +190,26 @@ static struct tegra_gpio_table common_gpio_table[] = {
>  	{ .gpio = TEGRA_GPIO_SD2_CD,		.enable = true },
>  	{ .gpio = TEGRA_GPIO_SD2_WP,		.enable = true },
>  	{ .gpio = TEGRA_GPIO_SD2_POWER,		.enable = true },
> +	{ .gpio = TEGRA_GPIO_CDC_IRQ,		.enable = true },
> +};
> +
> +static struct tegra_gpio_table seaboard_gpio_table[] = {
>  	{ .gpio = TEGRA_GPIO_LIDSWITCH,		.enable = true },
>  	{ .gpio = TEGRA_GPIO_POWERKEY,		.enable = true },
>  	{ .gpio = TEGRA_GPIO_HP_DET,		.enable = true },
>  	{ .gpio = TEGRA_GPIO_ISL29018_IRQ,	.enable = true },
> -	{ .gpio = TEGRA_GPIO_CDC_IRQ,		.enable = true },
>  	{ .gpio = TEGRA_GPIO_USB1,		.enable = true },
>  };
>  
> +static struct tegra_gpio_table ventana_gpio_table[] = {
> +	/* hp_det */
> +	{ .gpio = TEGRA_GPIO_PW2,		.enable = true },
> +	/* int_mic_en */
> +	{ .gpio = TEGRA_GPIO_PX0,		.enable = true },
> +	/* ext_mic_en */
> +	{ .gpio = TEGRA_GPIO_PX1,		.enable = true },
> +};

These should be given symbolical names instead.


-Olof