From: Kalle Valo <kvalo@qca.qualcomm.com>
To: kvalo@qca.qualcomm.com
Cc: ath6kl-devel@qualcomm.com, linux-wireless@vger.kernel.org
Subject: [PATCH 1/6] ath6kl: remove a workaround from ath6kl_cfg80211_stop()
Date: Thu, 08 Dec 2011 17:28:24 +0200 [thread overview]
Message-ID: <20111208152824.16924.31984.stgit@x201> (raw)
There's a workaround in ath6kl_cfg80211_stop() which emits disconnected
even when sme_state was disconnected. This is legacy from the old
staging driver and I can't repoduce the old problem anymore. I assume the
bug got fixed while the driver was cleaned up so let's get
rid of the hack.
This makes it possible to call ath6kl_cfg80211_stop from ath6kl_close()
which happens in a followup patch.
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath6kl/cfg80211.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index aa93527..5f12c04 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -2406,6 +2406,8 @@ void ath6kl_cfg80211_stop(struct ath6kl *ar)
}
switch (vif->sme_state) {
+ case SME_DISCONNECTED:
+ break;
case SME_CONNECTING:
cfg80211_connect_result(vif->ndev, vif->bssid, NULL, 0,
NULL, 0,
@@ -2413,12 +2415,6 @@ void ath6kl_cfg80211_stop(struct ath6kl *ar)
GFP_KERNEL);
break;
case SME_CONNECTED:
- default:
- /*
- * FIXME: oddly enough smeState is in DISCONNECTED during
- * suspend, why? Need to send disconnected event in that
- * state.
- */
cfg80211_disconnected(vif->ndev, 0, NULL, 0, GFP_KERNEL);
break;
}
next reply other threads:[~2011-12-08 15:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 15:28 Kalle Valo [this message]
2011-12-08 15:28 ` [PATCH 2/6] ath6kl: call ath6kl_cfg80211_stop() from ath6kl_close() Kalle Valo
2011-12-08 15:29 ` [PATCH 3/6] ath6kl: implement ath6kl_cfg80211_stop_all() Kalle Valo
2011-12-08 15:29 ` [PATCH 4/6] ath6kl: fix value of WOW_FILTER_SSID Kalle Valo
2011-12-08 15:29 ` [PATCH 5/6] ath6kl: fix reading of FW IE capabilities Kalle Valo
2011-12-08 15:29 ` [PATCH 6/6] ath6kl: implement scheduled scan Kalle Valo
2011-12-09 7:43 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111208152824.16924.31984.stgit@x201 \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.