From: Benjamin LaHaise <bcrl@kvack.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] add netpoll support for 802.1q vlans
Date: Thu, 8 Dec 2011 10:35:58 -0500 [thread overview]
Message-ID: <20111208153558.GE30652@kvack.org> (raw)
In-Reply-To: <20111208.000730.63159506168958262.davem@davemloft.net>
On Thu, Dec 08, 2011 at 12:07:30AM -0500, David Miller wrote:
> From: Benjamin LaHaise <bcrl@kvack.org>
> Date: Tue, 6 Dec 2011 20:04:24 -0500
>
> > Add netpoll support to 802.1q vlan devices. Based on the netpoll support
> > in the bridging code. Tested on a forced_eth device with netconsole.
> >
> > Signed-off-by: Benjamin LaHaise <bcrl@kvack.org>
>
> Bridging doesn't try to invoke a downstream netpoll operation at all,
> and neither should you.
Please have a look at net/bridge/br_device.c:br_netpoll_setup() which is
where the approach came from.
Getting netconsole over vlans working is a requirement for those of us
with machines plugged into ethernet switches that can't mix tagged and
untagged packets on their ethernet ports. I bumped into this while
trying to capture a kernel crash on such a machine which doesn't have any
external serial ports to use either.
> Also, please format your subject line correctly so I don't have to edit
> it when applying your patch. You need to add an appropriate, lowercase,
> subsystem prefix after the [PATCH] tag otherwise people scanning the
> shortlog in GIT can't figure out what area your patch is in.
>
> In this situation "vlan: " might be appropriate.
Sorry about that oversight, I'll try to remember for the future.
-ben
--
"Thought is the essence of where you are now."
next prev parent reply other threads:[~2011-12-08 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 1:04 [PATCH] add netpoll support for 802.1q vlans Benjamin LaHaise
2011-12-08 5:07 ` David Miller
2011-12-08 15:35 ` Benjamin LaHaise [this message]
2011-12-08 16:20 ` [PATCH net-next v2] vlan: add 802.1q netpoll support Benjamin LaHaise
2011-12-09 0:55 ` David Miller
2011-12-08 16:50 ` [PATCH] add netpoll support for 802.1q vlans David Miller
2011-12-08 9:14 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111208153558.GE30652@kvack.org \
--to=bcrl@kvack.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.