All of lore.kernel.org
 help / color / mirror / Atom feed
From: agk@sourceware.org <agk@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/lib/locking locking.h
Date: 8 Dec 2011 18:09:48 -0000	[thread overview]
Message-ID: <20111208180948.4884.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk at sourceware.org	2011-12-08 18:09:48

Modified files:
	lib/locking    : locking.h 

Log message:
	Update comments.  CLUSTER_VG belongs firmly to args[0].

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/locking/locking.h.diff?cvsroot=lvm2&r1=1.72&r2=1.73

--- LVM2/lib/locking/locking.h	2011/12/03 11:36:10	1.72
+++ LVM2/lib/locking/locking.h	2011/12/08 18:09:48	1.73
@@ -89,13 +89,14 @@
 #define LCK_LV		0x00000008U
 
 /*
- * Lock bits
+ * Lock bits.
+ * Bottom 8 bits except LCK_LOCAL form args[0] in cluster comms.
  */
 #define LCK_NONBLOCK	0x00000010U	/* Don't block waiting for lock? */
 #define LCK_HOLD	0x00000020U	/* Hold lock when lock_vol returns? */
+#define LCK_CLUSTER_VG	0x00000080U	/* VG is clustered */
+
 #define LCK_LOCAL	0x00000040U	/* Don't propagate to other nodes */
-// FIXME: not used in lock bits
-//#define LCK_CLUSTER_VG	0x00000080U	/* VG is clustered */
 #define LCK_CACHE	0x00000100U	/* Operation on cache only using P_ lock */
 #define LCK_ORIGIN_ONLY	0x00000200U	/* Operation should bypass any snapshots */
 #define LCK_REVERT	0x00000400U	/* Revert any incomplete change */
@@ -106,14 +107,14 @@
 #define LCK_PARTIAL_MODE        	0x01	/* Partial activation? */
 #define LCK_MIRROR_NOSYNC_MODE		0x02	/* Mirrors don't require sync */
 #define LCK_DMEVENTD_MONITOR_MODE	0x04	/* Register with dmeventd */
+
+/* Not yet used. */
 #define LCK_CONVERT			0x08	/* Convert existing lock */
+
 #define LCK_TEST_MODE			0x10    /* Test mode: No activation */
 #define LCK_ORIGIN_ONLY_MODE		0x20	/* Same as above */
 #define LCK_DMEVENTD_MONITOR_IGNORE     0x40	/* Whether to ignore dmeventd */
-
-// FIXME: conflict here (CLUSTER_VG is used here)
 #define LCK_REVERT_MODE			0x80	/* Remove inactive tables */
-#define LCK_CLUSTER_VG			0x80	/* VG is clustered */
 
 /*
  * Special cases of VG locks.



             reply	other threads:[~2011-12-08 18:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-08 18:09 agk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-04-24 12:17 LVM2/lib/locking locking.h zkabelac
2012-02-27  9:52 zkabelac
2011-12-03 11:36 mbroz
2011-12-03 11:34 mbroz
2010-05-19  1:49 agk
2009-10-01 14:15 ccaulfield
2009-07-24 18:26 agk
2007-11-15  2:55 agk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111208180948.4884.qmail@sourceware.org \
    --to=agk@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.