From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH 01 of 18] x86/mm: Code style fixes in mem_sharing.c Date: Thu, 8 Dec 2011 21:54:12 +0000 Message-ID: <20111208215412.GD87836@ocelot.phlegethon.org> References: <20111208111118.GA82565@ocelot.phlegethon.org> <22f47878379138be5d645f48b4db9ed3.squirrel@webmail.lagarcavilla.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <22f47878379138be5d645f48b4db9ed3.squirrel@webmail.lagarcavilla.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andres Lagar-Cavilla Cc: xen-devel@lists.xensource.com, ian.campbell@citrix.com, andres@gridcentric.ca, keir.xen@gmail.com, jbeulich@suse.com, ian.jackson@citrix.com, adin@gridcentric.ca List-Id: xen-devel@lists.xenproject.org At 08:16 -0800 on 08 Dec (1323332187), Andres Lagar-Cavilla wrote: > > At 02:47 -0500 on 08 Dec (1323312436), Andres Lagar-Cavilla wrote: > >> Harmless patch, with no functional changes, only code style issues. > >> > >> Signed-off-by: Andres Lagar-Cavilla > > > > ... > > > >> - return -2; > >> + return 0; > > > > Ahem. :) > > > > Tim. > Borderline, I'll admit. I can play down the tone of the header -- nothing > is really harmless :) > > The function will still produce the same outputs on the same inputs, with > cleaner code. Ah, so it will. I'll apply this, but in future I'd like long patches that do tedious whitespace fixups to _just_ have whitespace fixups. It reduces the chance of nasty surprises (and the chance that I'll have to read a long patch of tedious whitespace fixups more than once!) Tim.