From: Greg KH <greg@kroah.com>
To: "Ramirez Luna, Omar" <omar.ramirez@ti.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
devel@driverdev.osuosl.org, linux-omap@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH v2] staging: tidspbridge: request dmtimer clocks on init
Date: Thu, 8 Dec 2011 16:07:33 -0800 [thread overview]
Message-ID: <20111209000733.GA9504@kroah.com> (raw)
In-Reply-To: <CAB-zwWiH020HfovGF8CA-v9t8Pjc3kLbsXezN6ToLdyC4muHqA@mail.gmail.com>
On Thu, Dec 08, 2011 at 02:16:10PM -0600, Ramirez Luna, Omar wrote:
> On Thu, Dec 8, 2011 at 2:11 PM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> > On Sat, Nov 19, 2011 at 12:18 AM, Omar Ramirez Luna <omar.ramirez@ti.com> wrote:
> >> Given that dm timer framework doesn't support request of clocks
> >> by soft | hard irqs because some recent changes, tidspbridge needs
> >> to request its clocks on init and enable/disable them on demand.
> >>
> >> This was first seen on 3.2-rc1.
> >>
> >> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
> >
> > Tested-by: Felipe Contreras <felipe.contreras@gmail.com>
> > Reviewed-by: Felipe Contreras <felipe.contreras@gmail.com>
>
> Thanks!
>
> > Something the commit message didn't mention is that this fixes a nasty
> > continuous loop that happens as soon as you load the module.
>
> Indeed.
>
> > Definitely 3.2-fix material IMO :)
>
> I believe it was pushed to staging-next... I'm rooting so it can be
> pushed to staging-linus :)
As it wasn't originally stated that this was a problem that needed to be
fixed for 3.2, can it wait for 3.3-rc1? Especially given that there is
still discussion about this?
thanks,
greg k-h
next prev parent reply other threads:[~2011-12-09 0:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 22:18 [PATCH v2] staging: tidspbridge: request dmtimer clocks on init Omar Ramirez Luna
2011-12-07 22:11 ` Felipe Contreras
2011-12-08 19:10 ` Ramirez Luna, Omar
2011-12-08 19:50 ` Felipe Contreras
2011-12-08 20:14 ` Ramirez Luna, Omar
2011-12-08 20:11 ` Felipe Contreras
2011-12-08 20:16 ` Ramirez Luna, Omar
2011-12-09 0:07 ` Greg KH [this message]
2011-12-09 1:13 ` Felipe Contreras
2011-12-09 1:44 ` Ramirez Luna, Omar
2011-12-09 22:38 ` Greg KH
2011-12-10 11:55 ` Ramirez Luna, Omar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111209000733.GA9504@kroah.com \
--to=greg@kroah.com \
--cc=devel@driverdev.osuosl.org \
--cc=felipe.contreras@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-omap@vger.kernel.org \
--cc=omar.ramirez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.