From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v2] soc/lapis: add machine driver Date: Fri, 9 Dec 2011 16:43:38 +0800 Message-ID: <20111209084337.GJ26952@opensource.wolfsonmicro.com> References: <1322819115-15808-1-git-send-email-tomoya.rohm@gmail.com> <20111202153401.GX8245@opensource.wolfsonmicro.com> <20111205183223.GB7467@opensource.wolfsonmicro.com> <20111207132322.GA18837@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id B65C324390 for ; Fri, 9 Dec 2011 09:43:43 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Tomoya MORINAGA Cc: Dimitris Papastamos , alsa-devel@alsa-project.org, Lars-Peter Clausen , Mike Frysinger , qi.wang@intel.com, Takashi Iwai , linux-kernel@vger.kernel.org, yong.y.wang@intel.com, kok.howg.ewe@intel.com, Daniel Mack , Liam Girdwood , joel.clark@intel.com List-Id: alsa-devel@alsa-project.org On Fri, Dec 09, 2011 at 05:38:57PM +0900, Tomoya MORINAGA wrote: > Firstly, the above "dai_link structure" means below ? If yes, there is > no member "dai_fmt", right ? > 697 struct snd_soc_dai_link { As previously advised you should work against current development kernels. dai_fmt is present in current development kernels (and Linus' tree for that matter). > > + ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S | > > + SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS); > At the above point, do you mean I shouldn't set these formats( > SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS) > directly ? Yes. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752634Ab1LIInp (ORCPT ); Fri, 9 Dec 2011 03:43:45 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:54418 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751946Ab1LIIno (ORCPT ); Fri, 9 Dec 2011 03:43:44 -0500 Date: Fri, 9 Dec 2011 16:43:38 +0800 From: Mark Brown To: Tomoya MORINAGA Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , Dimitris Papastamos , Mike Frysinger , Daniel Mack , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com, kok.howg.ewe@intel.com Subject: Re: [PATCH v2] soc/lapis: add machine driver Message-ID: <20111209084337.GJ26952@opensource.wolfsonmicro.com> References: <1322819115-15808-1-git-send-email-tomoya.rohm@gmail.com> <20111202153401.GX8245@opensource.wolfsonmicro.com> <20111205183223.GB7467@opensource.wolfsonmicro.com> <20111207132322.GA18837@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: You will be awarded some great honor. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 09, 2011 at 05:38:57PM +0900, Tomoya MORINAGA wrote: > Firstly, the above "dai_link structure" means below ? If yes, there is > no member "dai_fmt", right ? > 697 struct snd_soc_dai_link { As previously advised you should work against current development kernels. dai_fmt is present in current development kernels (and Linus' tree for that matter). > > + ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S | > > + SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS); > At the above point, do you mean I shouldn't set these formats( > SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS) > directly ? Yes.