From: Johan Hedberg <johan.hedberg@gmail.com>
To: Frederic Danis <frederic.danis@linux.intel.com>
Cc: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH hciemu v2 1/2] Process Read Local AMP Info in hciemu
Date: Fri, 9 Dec 2011 10:48:28 +0200 [thread overview]
Message-ID: <20111209084828.GA24969@x220> (raw)
In-Reply-To: <4EE1CA0F.2040402@linux.intel.com>
Hi Frederic,
On Fri, Dec 09, 2011, Frederic Danis wrote:
> >>fdanis@fdanis-linux:bluez (master %)$ make
> >>make --no-print-directory all-am
> >> CC test/hciemu.o
> >>cc1: warnings being treated as errors
> >>test/hciemu.c: In function ‘hci_host_control’:
> >>test/hciemu.c:431: error: dereferencing pointer ‘({anonymous})’ does
> >>break strict-aliasing rules
> >>test/hciemu.c:431: note: initialized from here
> >>make[1]: *** [test/hciemu.o] Error 1
> >>make: *** [all] Error 2
> >
> >Cannot reproduce this problem on my Ubuntu 11.04. Are you sure the error is
> >attributed to my patch?
>
> Yes, I replaced line 431 by:
> sa.sin_port = ba.b[4];
> and there is no more build error.
Ok, so the line *is* correct but the function reported by gcc isn't.
This particular line was last changed way back in 2005 (check with git
blame) by a commit from Marcel so I don't see how your issue could have
been caused by recent changes. As I mentioned in the other email I'd
expect you to provide a proper patch for this with a good commit message
that explains why it is needed.
Johan
next prev parent reply other threads:[~2011-12-09 8:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 8:54 [PATCH hciemu v2 1/2] Process Read Local AMP Info in hciemu Emeltchenko Andrei
2011-12-08 8:54 ` [PATCH hciemu v2 2/2] Print features for AMP devices Emeltchenko Andrei
2011-12-08 9:40 ` [PATCH hciemu v2 1/2] Process Read Local AMP Info in hciemu Johan Hedberg
2011-12-08 14:58 ` Frederic Danis
2011-12-09 8:16 ` Emeltchenko Andrei
2011-12-09 8:42 ` Frederic Danis
2011-12-09 8:48 ` Johan Hedberg [this message]
2011-12-10 15:37 ` Syam Sidhardhan
2011-12-09 8:43 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111209084828.GA24969@x220 \
--to=johan.hedberg@gmail.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=frederic.danis@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.