From: Mike Frysinger <vapier@gentoo.org>
To: uclinux-dist-devel@blackfin.uclinux.org
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Sonic Zhang <sonic.adi@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: [uclinux-dist-devel] [PATCH 2/2] serial: bfin-uart: Remove ASYNC_CTS_FLOW flag for hardware automatic CTS.
Date: Fri, 9 Dec 2011 12:17:05 -0500 [thread overview]
Message-ID: <201112091217.07781.vapier@gentoo.org> (raw)
In-Reply-To: <20111209111205.04780196@pyramind.ukuu.org.uk>
[-- Attachment #1: Type: Text/Plain, Size: 406 bytes --]
On Friday 09 December 2011 06:12:05 Alan Cox wrote:
> > +#ifdef CONFIG_SERIAL_BFIN_CTSRTS
> >
> > uart->port.flags |= ASYNC_CTS_FLOW;
> >
> > +#endif
>
> As an aside could the cts/hard cts etc be passed as properties to the
> platform device rather than ifdeffed ?
most platforms don't bother with flow control, so we made support in the driver
optional to keep things smaller.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-12-09 17:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 6:00 [PATCH 1/2] serial: bfin-uart: Enable hardware automatic CTS only when CTS pin is available Sonic Zhang
2011-12-09 6:00 ` Sonic Zhang
2011-12-09 6:00 ` [PATCH 2/2] serial: bfin-uart: Remove ASYNC_CTS_FLOW flag for hardware automatic CTS Sonic Zhang
2011-12-09 6:00 ` Sonic Zhang
2011-12-09 11:12 ` Alan Cox
2011-12-09 11:12 ` Alan Cox
2011-12-09 17:17 ` Mike Frysinger [this message]
2011-12-12 5:20 ` Sonic Zhang
2011-12-10 3:09 ` [PATCH 1/2] serial: bfin-uart: Enable hardware automatic CTS only when CTS pin is available Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112091217.07781.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sonic.adi@gmail.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.