All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Borislav Petkov <bp@amd64.org>,
	LKML <linux-kernel@vger.kernel.org>, X86-ML <x86@kernel.org>,
	EDAC devel <linux-edac@vger.kernel.org>
Subject: Re: [PATCH 2/2] x86, MCE: Drain mcelog buffer
Date: Fri, 9 Dec 2011 19:24:48 +0100	[thread overview]
Message-ID: <20111209182448.GA29629@gere.osrc.amd.com> (raw)
In-Reply-To: <0207C53569FE594381A4F2EB66570B2A018EFB7762@orsmsx508.amr.corp.intel.com>

On Fri, Dec 09, 2011 at 10:19:02AM -0800, Luck, Tony wrote:
> void mce_register_decode_chain(struct notifier_block *nb)
>  {
>  	atomic_notifier_chain_register(&x86_mce_decoder_chain, nb);
> +	drain_mcelog_buffer();
>  }
> 
> Won't this dump all the pended stuff to the *first* guy to
> register - but subsequent interested parties will still
> miss out?

Yeah,

this is currently assuming that we have one consumer per system. At
least this is the case on AMD: MCE decoder registers and decodes the
errors. It will pass a subset of the MCEs (DRAM ECCs) to amd64_edac for
additional massaging.

Do you see a usecase for multiple consumers?

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551

  reply	other threads:[~2011-12-09 18:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-08 14:08 [PATCH 0/2] x86, MCE: Catch the early worm Borislav Petkov
2011-12-08 14:08 ` [PATCH 1/2] x86, mce: Add wrappers for registering on the decode chain Borislav Petkov
2011-12-08 14:08 ` [PATCH 2/2] x86, MCE: Drain mcelog buffer Borislav Petkov
2011-12-09 18:19   ` Luck, Tony
2011-12-09 18:24     ` Borislav Petkov [this message]
2011-12-09 18:40       ` Luck, Tony
2011-12-09 19:18         ` Borislav Petkov
2011-12-09 22:08           ` Luck, Tony
2011-12-12 14:19             ` Borislav Petkov
2011-12-09  6:16 ` [PATCH 0/2] x86, MCE: Catch the early worm Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111209182448.GA29629@gere.osrc.amd.com \
    --to=bp@amd64.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.