From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] kvm tools: Fix serial port probing
Date: Fri, 9 Dec 2011 21:10:23 +0100
Message-ID: <20111209201023.GA27932@elte.hu>
References: <1323429377-5140-1-git-send-email-levinsasha928@gmail.com>
 <CAOJsxLHW=FO7q-0U=Mpccno_e5zpXCUFR2GSKa0NJMrjYr=8yQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Sasha Levin <levinsasha928@gmail.com>, gorcunov@gmail.com,
	asias.hejun@gmail.com, kvm@vger.kernel.org
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.mail.elte.hu ([157.181.151.9]:47436 "EHLO mx2.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751485Ab1LIUMI (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 9 Dec 2011 15:12:08 -0500
Content-Disposition: inline
In-Reply-To: <CAOJsxLHW=FO7q-0U=Mpccno_e5zpXCUFR2GSKa0NJMrjYr=8yQ@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Pekka Enberg <penberg@kernel.org> wrote:

> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0dev->ier =A0 =A0 =A0=
 =A0=3D ioport__read8(data) & 0x3f;
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 kvm__irq_line(kvm, de=
v->irq, dev->ier?1:0);
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0break;
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0case UART_LCR:
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0dev->lcr =A0 =A0 =A0=
 =A0=3D ioport__read8(data);
>=20
> Applied, thanks!
>=20
> Ingo, does this fix the occasional slowdowns you are seeing?

Indeed it does!

I still see things like 'top' refreshes progressing - i.e.=20
taking something like 100-200 msecs to finish, but it's a *lot*=20
faster now.

Thanks,

	Ingo