From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] NET: NE2000: Cleanup IO accessors
Date: Sun, 11 Dec 2011 02:24:51 -0500 [thread overview]
Message-ID: <201112110224.52449.vapier@gentoo.org> (raw)
In-Reply-To: <1323565772-4498-1-git-send-email-marek.vasut@gmail.com>
On Saturday 10 December 2011 20:09:30 Marek Vasut wrote:
> Introduce ne2k_register_io(in, out), which allows user to supply two
> functions. One for reading data from the card, the other for writing data
> to the card. Then introduce drivers' private data, which carry pointers to
> these functions and are passed throughout the driver.
where are the users of this new API ? as it stands, i just see bloat. every
register access is now an indirect function call ? what's the point ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111211/4e87fce5/attachment.pgp>
next prev parent reply other threads:[~2011-12-11 7:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-11 1:09 [U-Boot] [PATCH 1/2] NET: NE2000: Cleanup IO accessors Marek Vasut
2011-12-11 1:09 ` [U-Boot] [PATCH 2/2] NET: NE2000: Hide dp83902a_priv_data_t into ne2k_private_data Marek Vasut
2011-12-11 7:24 ` Mike Frysinger [this message]
2011-12-11 13:42 ` [U-Boot] [PATCH 1/2] NET: NE2000: Cleanup IO accessors Marek Vasut
2011-12-12 5:45 ` Mike Frysinger
2011-12-12 10:17 ` Marek Vasut
2011-12-16 17:33 ` Mike Frysinger
2011-12-16 18:13 ` Marek Vasut
2011-12-16 19:32 ` Mike Frysinger
2011-12-16 20:36 ` Marek Vasut
2012-07-10 21:41 ` Joe Hershberger
2012-07-13 10:50 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112110224.52449.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.