All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MAKEALL: Add -l option to only list build targets
Date: Mon, 12 Dec 2011 00:49:18 -0500	[thread overview]
Message-ID: <201112120049.19430.vapier@gentoo.org> (raw)
In-Reply-To: <201112041232.47531.marek.vasut@gmail.com>

On Sunday 04 December 2011 06:32:47 Marek Vasut wrote:
> > Should it be an equality operator instead of an assigning one?  i.e:
> > 
> > [ "$ONLY_LIST" == "y" ] && return
> 
> 2) It's the same thing ... = and == in shell scripting.

while this is true for the particular piece of code quoted, in general, this 
statement is false.  "==" is a bashism (it is not part of POSIX), and it 
allows you to do comparisons that the "=" operator does not (such as pattern 
matching).

this code uses "=" everywhere with single brackets.  any new code should stick 
to that form.  if you want to use "==", it should be with double brackets, and 
probably have a good reason for it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111212/adf1e143/attachment.pgp>

  reply	other threads:[~2011-12-12  5:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-03  7:32 [U-Boot] [PATCH] MAKEALL: Add -l option to only list build targets Marek Vasut
2011-12-03  7:57 ` Mike Frysinger
2011-12-03  8:23   ` Marek Vasut
2011-12-03  9:19     ` Mike Frysinger
2011-12-03  9:36       ` Marek Vasut
2011-12-03 17:03         ` Mike Frysinger
2011-12-04  2:44   ` Qinglin Ye
2011-12-04 11:32     ` Marek Vasut
2011-12-12  5:49       ` Mike Frysinger [this message]
2011-12-03 16:06 ` Kumar Gala
2011-12-03 17:02   ` Marek Vasut
2011-12-06 21:14 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201112120049.19430.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.