From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Jangam <ashish.jangam@kpitcummins.com>
Cc: linux-kernel@vger.kernel.org, Dajun <dajun.chen@diasemi.com>,
arnd@arndb.de, linaro-dev@lists.linaro.org, eric.miao@linaro.org
Subject: Re: [PATCH 02/06] MFD: DA9052/53 MFD core module v9 Added ADC support
Date: Mon, 12 Dec 2011 12:52:59 +0800 [thread overview]
Message-ID: <20111212045258.GD2806@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1323440166.23171.70.camel@dhruva>
On Fri, Dec 09, 2011 at 07:46:06PM +0530, Ashish Jangam wrote:
> + req = kzalloc(sizeof(*req), GFP_KERNEL);
> + if (!req)
> + return -ENOMEM;
> + init_completion(&req->done);
> + req->input = channel;
> +
> + if (channel > DA9052_ADC_VBBAT)
> + return -EINVAL;
This will leak the request.
> + list_del(&req->list);
> +err:
> + mutex_unlock(&da9052->auxadc_lock);
> + return ret;
> +}
> +EXPORT_SYMBOL_GPL(da9052_adc_manual_read);
In fact is req freed at all?
next prev parent reply other threads:[~2011-12-12 4:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 14:16 [PATCH 02/06] MFD: DA9052/53 MFD core module v9 Added ADC support Ashish Jangam
2011-12-12 4:52 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-09 8:46 Ashish Jangam
2012-01-09 22:37 ` Mark Brown
2012-01-10 5:50 ` Ashish Jangam
2012-01-10 22:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212045258.GD2806@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=ashish.jangam@kpitcummins.com \
--cc=dajun.chen@diasemi.com \
--cc=eric.miao@linaro.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.