From: mel@csn.ul.ie (Mel Gorman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/11] mm: mmzone: introduce zone_pfn_same_memmap()
Date: Mon, 12 Dec 2011 14:40:30 +0000 [thread overview]
Message-ID: <20111212144030.GF3277@csn.ul.ie> (raw)
In-Reply-To: <op.v6dr4pj43l0zgt@mpn-glaptop>
On Mon, Dec 12, 2011 at 03:35:03PM +0100, Michal Nazarewicz wrote:
> >On Fri, Nov 18, 2011 at 05:43:10PM +0100, Marek Szyprowski wrote:
> >>From: Michal Nazarewicz <mina86@mina86.com>
> >>diff --git a/mm/compaction.c b/mm/compaction.c
> >>index 6afae0e..09c9702 100644
> >>--- a/mm/compaction.c
> >>+++ b/mm/compaction.c
> >>@@ -111,7 +111,10 @@ skip:
> >>
> >> next:
> >> pfn += isolated;
> >>- page += isolated;
> >>+ if (zone_pfn_same_memmap(pfn - isolated, pfn))
> >>+ page += isolated;
> >>+ else
> >>+ page = pfn_to_page(pfn);
> >> }
>
> On Mon, 12 Dec 2011 15:19:53 +0100, Mel Gorman <mel@csn.ul.ie> wrote:
> >Is this necessary?
> >
> >We are isolating pages, the largest of which is a MAX_ORDER_NR_PAGES
> >page. [...]
>
> This is not true for CMA.
>
To be clear, I'm referring to a single page being isolated here. It may
or may not be a high-order page but it's still going to be less then
MAX_ORDER_NR_PAGES so you should be able check when a new block is
entered and pfn_to_page is necessary.
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mel@csn.ul.ie>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-mm@kvack.org,
linaro-mm-sig@lists.linaro.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Ankita Garg <ankita@in.ibm.com>,
Daniel Walker <dwalker@codeaurora.org>,
Arnd Bergmann <arnd@arndb.de>,
Jesse Barker <jesse.barker@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
Shariq Hasnain <shariq.hasnain@linaro.org>,
Chunsang Jeong <chunsang.jeong@linaro.org>,
Dave Hansen <dave@linux.vnet.ibm.com>
Subject: Re: [PATCH 03/11] mm: mmzone: introduce zone_pfn_same_memmap()
Date: Mon, 12 Dec 2011 14:40:30 +0000 [thread overview]
Message-ID: <20111212144030.GF3277@csn.ul.ie> (raw)
In-Reply-To: <op.v6dr4pj43l0zgt@mpn-glaptop>
On Mon, Dec 12, 2011 at 03:35:03PM +0100, Michal Nazarewicz wrote:
> >On Fri, Nov 18, 2011 at 05:43:10PM +0100, Marek Szyprowski wrote:
> >>From: Michal Nazarewicz <mina86@mina86.com>
> >>diff --git a/mm/compaction.c b/mm/compaction.c
> >>index 6afae0e..09c9702 100644
> >>--- a/mm/compaction.c
> >>+++ b/mm/compaction.c
> >>@@ -111,7 +111,10 @@ skip:
> >>
> >> next:
> >> pfn += isolated;
> >>- page += isolated;
> >>+ if (zone_pfn_same_memmap(pfn - isolated, pfn))
> >>+ page += isolated;
> >>+ else
> >>+ page = pfn_to_page(pfn);
> >> }
>
> On Mon, 12 Dec 2011 15:19:53 +0100, Mel Gorman <mel@csn.ul.ie> wrote:
> >Is this necessary?
> >
> >We are isolating pages, the largest of which is a MAX_ORDER_NR_PAGES
> >page. [...]
>
> This is not true for CMA.
>
To be clear, I'm referring to a single page being isolated here. It may
or may not be a high-order page but it's still going to be less then
MAX_ORDER_NR_PAGES so you should be able check when a new block is
entered and pfn_to_page is necessary.
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mel@csn.ul.ie>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-mm@kvack.org,
linaro-mm-sig@lists.linaro.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Ankita Garg <ankita@in.ibm.com>,
Daniel Walker <dwalker@codeaurora.org>,
Arnd Bergmann <arnd@arndb.de>,
Jesse Barker <jesse.barker@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
Shariq Hasnain <shariq.hasnain@linaro.org>,
Chunsang Jeong <chunsang.jeong@linaro.org>,
Dave Hansen <dave@linux.vnet.ibm.com>
Subject: Re: [PATCH 03/11] mm: mmzone: introduce zone_pfn_same_memmap()
Date: Mon, 12 Dec 2011 14:40:30 +0000 [thread overview]
Message-ID: <20111212144030.GF3277@csn.ul.ie> (raw)
In-Reply-To: <op.v6dr4pj43l0zgt@mpn-glaptop>
On Mon, Dec 12, 2011 at 03:35:03PM +0100, Michal Nazarewicz wrote:
> >On Fri, Nov 18, 2011 at 05:43:10PM +0100, Marek Szyprowski wrote:
> >>From: Michal Nazarewicz <mina86@mina86.com>
> >>diff --git a/mm/compaction.c b/mm/compaction.c
> >>index 6afae0e..09c9702 100644
> >>--- a/mm/compaction.c
> >>+++ b/mm/compaction.c
> >>@@ -111,7 +111,10 @@ skip:
> >>
> >> next:
> >> pfn += isolated;
> >>- page += isolated;
> >>+ if (zone_pfn_same_memmap(pfn - isolated, pfn))
> >>+ page += isolated;
> >>+ else
> >>+ page = pfn_to_page(pfn);
> >> }
>
> On Mon, 12 Dec 2011 15:19:53 +0100, Mel Gorman <mel@csn.ul.ie> wrote:
> >Is this necessary?
> >
> >We are isolating pages, the largest of which is a MAX_ORDER_NR_PAGES
> >page. [...]
>
> This is not true for CMA.
>
To be clear, I'm referring to a single page being isolated here. It may
or may not be a high-order page but it's still going to be less then
MAX_ORDER_NR_PAGES so you should be able check when a new block is
entered and pfn_to_page is necessary.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-12-12 14:40 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 16:43 [PATCHv17 0/11] Contiguous Memory Allocator Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` [PATCH 01/11] mm: page_alloc: handle MIGRATE_ISOLATE in free_pcppages_bulk() Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-12-12 13:42 ` Mel Gorman
2011-12-12 13:42 ` Mel Gorman
2011-12-12 13:42 ` Mel Gorman
2011-12-12 14:23 ` Michal Nazarewicz
2011-12-12 14:23 ` Michal Nazarewicz
2011-12-12 14:23 ` Michal Nazarewicz
2011-12-12 14:42 ` Mel Gorman
2011-12-12 14:42 ` Mel Gorman
2011-12-12 14:42 ` Mel Gorman
2011-11-18 16:43 ` [PATCH 02/11] mm: compaction: introduce isolate_{free,migrate}pages_range() Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-12-12 14:07 ` Mel Gorman
2011-12-12 14:07 ` Mel Gorman
2011-12-12 14:07 ` Mel Gorman
2011-12-12 15:22 ` Michal Nazarewicz
2011-12-12 15:22 ` Michal Nazarewicz
2011-12-12 15:22 ` Michal Nazarewicz
2011-12-12 16:30 ` Mel Gorman
2011-12-12 16:30 ` Mel Gorman
2011-12-12 16:30 ` Mel Gorman
2011-12-12 16:46 ` Michal Nazarewicz
2011-12-12 16:46 ` Michal Nazarewicz
2011-12-12 16:46 ` Michal Nazarewicz
2011-12-12 17:20 ` Mel Gorman
2011-12-12 17:20 ` Mel Gorman
2011-12-12 17:20 ` Mel Gorman
2011-11-18 16:43 ` [PATCH 03/11] mm: mmzone: introduce zone_pfn_same_memmap() Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-12-12 14:19 ` Mel Gorman
2011-12-12 14:19 ` Mel Gorman
2011-12-12 14:19 ` Mel Gorman
2011-12-12 14:35 ` Michal Nazarewicz
2011-12-12 14:35 ` Michal Nazarewicz
2011-12-12 14:35 ` Michal Nazarewicz
2011-12-12 14:40 ` Mel Gorman [this message]
2011-12-12 14:40 ` Mel Gorman
2011-12-12 14:40 ` Mel Gorman
2011-12-12 14:51 ` Michal Nazarewicz
2011-12-12 14:51 ` Michal Nazarewicz
2011-12-12 14:51 ` Michal Nazarewicz
2011-12-12 15:51 ` Mel Gorman
2011-12-12 15:51 ` Mel Gorman
2011-12-12 15:51 ` Mel Gorman
2011-11-18 16:43 ` [PATCH 04/11] mm: compaction: export some of the functions Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-12-12 14:29 ` Mel Gorman
2011-12-12 14:29 ` Mel Gorman
2011-12-12 14:29 ` Mel Gorman
2011-12-12 14:41 ` Michal Nazarewicz
2011-12-12 14:41 ` Michal Nazarewicz
2011-12-12 14:41 ` Michal Nazarewicz
2011-12-12 15:40 ` Mel Gorman
2011-12-12 15:40 ` Mel Gorman
2011-12-12 15:40 ` Mel Gorman
2011-12-12 15:46 ` Michal Nazarewicz
2011-12-12 15:46 ` Michal Nazarewicz
2011-12-12 15:46 ` Michal Nazarewicz
2011-12-12 16:22 ` Arnd Bergmann
2011-12-12 16:22 ` Arnd Bergmann
2011-12-12 16:22 ` Arnd Bergmann
2011-11-18 16:43 ` [PATCH 05/11] mm: page_alloc: introduce alloc_contig_range() Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` [PATCH 06/11] mm: mmzone: MIGRATE_CMA migration type added Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` [PATCH 07/11] mm: page_isolation: MIGRATE_CMA isolation functions added Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` [PATCH 08/11] drivers: add Contiguous Memory Allocator Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` [PATCH 09/11] X86: integrate CMA with DMA-mapping subsystem Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` [PATCH 10/11] ARM: " Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` [PATCH 11/11] ARM: Samsung: use CMA for 2 memory banks for s5p-mfc device Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 16:43 ` Marek Szyprowski
2011-11-18 21:20 ` [Linaro-mm-sig] [PATCHv17 0/11] Contiguous Memory Allocator sandeep patil
2011-11-18 21:20 ` sandeep patil
2011-11-18 21:20 ` sandeep patil
2011-11-18 21:26 ` Michal Nazarewicz
2011-11-18 21:26 ` Michal Nazarewicz
2011-11-18 21:26 ` Michal Nazarewicz
2011-11-18 23:30 ` sandeep patil
2011-11-18 23:30 ` sandeep patil
2011-11-18 23:30 ` sandeep patil
2011-11-19 18:09 ` Michal Nazarewicz
2011-11-19 18:09 ` Michal Nazarewicz
2011-11-19 18:09 ` Michal Nazarewicz
2011-11-25 16:43 ` [PATCH] mm: cma: hack/workaround for some allocation issues Marek Szyprowski
2011-11-25 16:43 ` Marek Szyprowski
2011-11-25 16:43 ` Marek Szyprowski
2011-11-25 21:08 ` Michal Nazarewicz
2011-11-25 21:08 ` Michal Nazarewicz
2011-11-25 21:08 ` Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212144030.GF3277@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.