From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: ceph, cifs, nfs, fuse: boolean and / or confusion Date: Mon, 12 Dec 2011 15:54:23 -0800 Message-ID: <20111212155423.24543d6a.akpm@linux-foundation.org> References: <4EE688FC.8090606@gmail.com> <20111212152856.871a8301.akpm@linux-foundation.org> <1323733153.13849.17.camel@lade.trondhjem.org> <1323733511.13849.19.camel@lade.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: roel , LKML , sage-BnTBU8nroG7k1uMJSBkQmQ@public.gmane.org, Steve French , linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Miklos Szeredi , fuse-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Trond Myklebust Return-path: In-Reply-To: <1323733511.13849.19.camel-SyLVLa/KEI9HwK5hSS5vWB2eb7JE58TQ@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-cifs.vger.kernel.org On Mon, 12 Dec 2011 18:45:11 -0500 Trond Myklebust wrote: > On Mon, 2011-12-12 at 18:39 -0500, Trond Myklebust wrote: > > > As far as NFS is concerned, it reverts a regression. NFS only used to > > run revalidate_file_size() for SEEK_END prior to commit > > 06222e491e663dac939f04b125c9dc52126a75c4. I accept that we now also need > > to run it for SEEK_HOLE and SEEK_DATA, but we've never had to do so for > > SEEK_SET and SEEK_CUR. > > BTW: The regression exists in 3.1, so this is probably a stable > candidate... > I'd prefer not to merge this one unless all four fs maintainers have reviewed and preferably tested it. Also, in view of your earlier email the changelog for this patch needs updating for NFS and probably other filesystems. So please prepare and send the NFS patch, with a Reported-by:roel? -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail.linuxfoundation.org ([140.211.169.12]:57732 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346Ab1LLXyZ (ORCPT ); Mon, 12 Dec 2011 18:54:25 -0500 Date: Mon, 12 Dec 2011 15:54:23 -0800 From: Andrew Morton To: Trond Myklebust Cc: roel , LKML , sage@newdream.net, Steve French , linux-cifs@vger.kernel.org, Miklos Szeredi , fuse-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org Subject: Re: ceph, cifs, nfs, fuse: boolean and / or confusion Message-Id: <20111212155423.24543d6a.akpm@linux-foundation.org> In-Reply-To: <1323733511.13849.19.camel@lade.trondhjem.org> References: <4EE688FC.8090606@gmail.com> <20111212152856.871a8301.akpm@linux-foundation.org> <1323733153.13849.17.camel@lade.trondhjem.org> <1323733511.13849.19.camel@lade.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, 12 Dec 2011 18:45:11 -0500 Trond Myklebust wrote: > On Mon, 2011-12-12 at 18:39 -0500, Trond Myklebust wrote: > > > As far as NFS is concerned, it reverts a regression. NFS only used to > > run revalidate_file_size() for SEEK_END prior to commit > > 06222e491e663dac939f04b125c9dc52126a75c4. I accept that we now also need > > to run it for SEEK_HOLE and SEEK_DATA, but we've never had to do so for > > SEEK_SET and SEEK_CUR. > > BTW: The regression exists in 3.1, so this is probably a stable > candidate... > I'd prefer not to merge this one unless all four fs maintainers have reviewed and preferably tested it. Also, in view of your earlier email the changelog for this patch needs updating for NFS and probably other filesystems. So please prepare and send the NFS patch, with a Reported-by:roel?